<table><tr><td style="">lbeltrame added a comment.
</td><a style="text-decoration: none; padding: 4px 8px; margin: 0 8px 8px; float: right; color: #464C5C; font-weight: bold; border-radius: 3px; background-color: #F7F7F9; background-image: linear-gradient(to bottom,#fff,#f1f0f1); display: inline-block; border: 1px solid rgba(71,87,120,.2);" href="https://phabricator.kde.org/D16490">View Revision</a></tr></table><br /><div><div><p>Generally looks OK to me, one note on <tt style="background: #ebebeb; font-size: 13px;">QDir::separator()</tt> usage.</p></div></div><br /><div><strong>INLINE COMMENTS</strong><div><div style="margin: 6px 0 12px 0;"><div style="border: 1px solid #C7CCD9; border-radius: 3px;"><div style="padding: 0; background: #F7F7F7; border-color: #e3e4e8; border-style: solid; border-width: 0 0 1px 0; margin: 0;"><div style="color: #74777d; background: #eff2f4; padding: 6px 8px; overflow: hidden;"><a style="float: right; text-decoration: none;" href="https://phabricator.kde.org/D16490#inline-89841">View Inline</a><span style="color: #4b4d51; font-weight: bold;">xmlextractortest.cpp:38</span></div>
<div style="font: 11px/15px "Menlo", "Consolas", "Monaco", monospace; white-space: pre-wrap; clear: both; padding: 4px 0; margin: 0;"><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);"><span class="p">{</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);">    <span style="color: #aa4000">return</span> <span class="n">QLatin1String</span><span class="p">(</span><span class="n">INDEXER_TESTS_SAMPLE_FILES_PATH</span><span class="p">)</span> <span style="color: #aa2211">+</span> <span class="n">QDir</span><span style="color: #aa2211">::</span><span class="n">separator</span><span class="p">()</span> <span style="color: #aa2211">+</span> <span class="n">fileName</span><span class="p">;</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);"><span class="p">}</span>
</div></div></div>
<div style="margin: 8px 0; padding: 0 12px;"><p style="padding: 0; margin: 8px;">IIRC you shouldn't use <tt style="background: #ebebeb; font-size: 13px;">QDir::separator()</tt>.  See <a href="http://agateau.com/2015/qdir-separator-considered-harmful/" class="remarkup-link" target="_blank" rel="noreferrer">http://agateau.com/2015/qdir-separator-considered-harmful/</a></p></div></div></div></div></div><br /><div><strong>REPOSITORY</strong><div><div>R286 KFileMetaData</div></div></div><br /><div><strong>REVISION DETAIL</strong><div><a href="https://phabricator.kde.org/D16490">https://phabricator.kde.org/D16490</a></div></div><br /><div><strong>To: </strong>bruns, Frameworks, astippich<br /><strong>Cc: </strong>lbeltrame, kde-frameworks-devel, Baloo, ashaposhnikov, michaelh, astippich, spoorun, ngraham, bruns, abrahams<br /></div>