D16249: Warn user before copy/move job if the file size exceeds the maximum possible file size in FAT32 file system(4 GB)

[Nathaniel Graham]

ngraham added inline comments.

INLINE COMMENTS

> bruns wrote in job_error.cpp:249
> %1 with quotes please, as it can contain whitespace, so it would be hard to spot where the filename ends.
> I would also prefer a sentence where the reason is given first, e.g.
> `The destination filesystem only supports files up to 4GB. "%1" is to large an can not be transferred.`

None of the other error messages use quotes around the filenames. What's most semantically correct would be to change `i18n` to `xi18n` and wrap the filename/path token in `<filename></filename>` tags (this is exactly what they're for). We can do that in this patch, and then change it for all the other error messages (as appropriate) in another patch.

Also, in terms of wording, the HIG recommends putting the most important part of the sentence first, which in this case would be the error message; the explanation would go second. See https://hig.kde.org/style/writing/wording.html. So the current sentence may be a bit long, but it's structurally correct as-is.

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D16249

To: shubham, ngraham, elvisangelaccio, #frameworks
Cc: bruns, kde-frameworks-devel, michaelh, ngraham
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20181018/0dad36f2/attachment.html>