D16249: Warn user before copy/move job if the file size exceeds the maximum possible file size in FAT32 file system(4 GB)

[Nathaniel Graham]

ngraham added inline comments.

INLINE COMMENTS

> global.h:249
> +    ERR_CANNOT_CREATE_SLAVE = KJob::UserDefinedError + 73, ///< used by Slave::createSlave, @since 5.30
> +    ERR_FILE_TOO_LARGE_FOR_FAT32 = KJob::UserDefinedError + 74
>  };

Please add a comment with `@since` to this

> job_error.cpp:253
>      default:
> -        result = i18n("Unknown error code %1\n%2\nPlease send a full bug report at https://bugs.kde.org.",  errorCode,  errorText);
> +        result = i18n("Unknown error code %1\n%2\nPlease send a full bug report at http://bugs.kde.org.",  errorCode,  errorText);
>          break;

Unrelated and incorrect change: `https` is correct here, so please revert.

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D16249

To: shubham, ngraham, elvisangelaccio, #frameworks
Cc: kde-frameworks-devel, michaelh, ngraham, bruns
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20181018/5ed124fc/attachment.html>