<table><tr><td style="">ngraham added inline comments.
</td><a style="text-decoration: none; padding: 4px 8px; margin: 0 8px 8px; float: right; color: #464C5C; font-weight: bold; border-radius: 3px; background-color: #F7F7F9; background-image: linear-gradient(to bottom,#fff,#f1f0f1); display: inline-block; border: 1px solid rgba(71,87,120,.2);" href="https://phabricator.kde.org/D16249">View Revision</a></tr></table><br /><div><strong>INLINE COMMENTS</strong><div><div style="margin: 6px 0 12px 0;"><div style="border: 1px solid #C7CCD9; border-radius: 3px;"><div style="padding: 0; background: #F7F7F7; border-color: #e3e4e8; border-style: solid; border-width: 0 0 1px 0; margin: 0;"><div style="color: #74777d; background: #eff2f4; padding: 6px 8px; overflow: hidden;"><a style="float: right; text-decoration: none;" href="https://phabricator.kde.org/D16249#inline-88711">View Inline</a><span style="color: #4b4d51; font-weight: bold;">global.h:249</span></div>
<div style="font: 11px/15px "Menlo", "Consolas", "Monaco", monospace; white-space: pre-wrap; clear: both; padding: 4px 0; margin: 0;"><div style="padding: 0 8px; margin: 0 4px; background: rgba(251, 175, 175, .7);"> <span class="n">ERR_CANNOT_CREATE_SLAVE</span> <span style="color: #aa2211">=</span> <span class="n">KJob</span><span style="color: #aa2211">::</span><span class="n">UserDefinedError</span> <span style="color: #aa2211">+</span> <span style="color: #601200">73</span> <span style="color: #74777d">///< used by Slave::createSlave, @since 5.30</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);"> <span class="n">ERR_CANNOT_CREATE_SLAVE</span> <span style="color: #aa2211">=</span> <span class="n">KJob</span><span style="color: #aa2211">::</span><span class="n">UserDefinedError</span> <span style="color: #aa2211">+</span> <span style="color: #601200">73<span class="bright"></span></span><span class="bright"></span><span class="p"><span class="bright">,</span></span> <span style="color: #74777d">///< used by Slave::createSlave, @since 5.30</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);"> <span class="n">ERR_FILE_TOO_LARGE_FOR_FAT32</span> <span style="color: #aa2211">=</span> <span class="n">KJob</span><span style="color: #aa2211">::</span><span class="n">UserDefinedError</span> <span style="color: #aa2211">+</span> <span style="color: #601200">74</span>
</div><div style="padding: 0 8px; margin: 0 4px; "><span class="p">};</span>
</div></div></div>
<div style="margin: 8px 0; padding: 0 12px;"><p style="padding: 0; margin: 8px;">Please add a comment with <tt style="background: #ebebeb; font-size: 13px;">@since</tt> to this</p></div></div><br /><div style="border: 1px solid #C7CCD9; border-radius: 3px;"><div style="padding: 0; background: #F7F7F7; border-color: #e3e4e8; border-style: solid; border-width: 0 0 1px 0; margin: 0;"><div style="color: #74777d; background: #eff2f4; padding: 6px 8px; overflow: hidden;"><a style="float: right; text-decoration: none;" href="https://phabricator.kde.org/D16249#inline-88710">View Inline</a><span style="color: #4b4d51; font-weight: bold;">job_error.cpp:253</span></div>
<div style="font: 11px/15px "Menlo", "Consolas", "Monaco", monospace; white-space: pre-wrap; clear: both; padding: 4px 0; margin: 0;"><div style="padding: 0 8px; margin: 0 4px; "> <span style="color: #aa4000">default</span><span style="color: #aa2211">:</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(251, 175, 175, .7);"> <span class="n">result</span> <span style="color: #aa2211">=</span> <span class="n">i18n</span><span class="p">(</span><span style="color: #766510">"Unknown error code %1</span><span style="color: #bb6622">\n</span><span style="color: #766510">%2</span><span style="color: #bb6622">\n</span><span style="color: #766510">Please send a full bug report at http<span class="bright">s</span>://bugs.kde.org."</span><span class="p">,</span> <span class="n">errorCode</span><span class="p">,</span> <span class="n">errorText</span><span class="p">);</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);"> <span class="n">result</span> <span style="color: #aa2211">=</span> <span class="n">i18n</span><span class="p">(</span><span style="color: #766510">"Unknown error code %1</span><span style="color: #bb6622">\n</span><span style="color: #766510">%2</span><span style="color: #bb6622">\n</span><span style="color: #766510">Please send a full bug report at http://bugs.kde.org."</span><span class="p">,</span> <span class="n">errorCode</span><span class="p">,</span> <span class="n">errorText</span><span class="p">);</span>
</div><div style="padding: 0 8px; margin: 0 4px; "> <span style="color: #aa4000">break</span><span class="p">;</span>
</div></div></div>
<div style="margin: 8px 0; padding: 0 12px;"><p style="padding: 0; margin: 8px;">Unrelated and incorrect change: <tt style="background: #ebebeb; font-size: 13px;">https</tt> is correct here, so please revert.</p></div></div></div></div></div><br /><div><strong>REPOSITORY</strong><div><div>R241 KIO</div></div></div><br /><div><strong>REVISION DETAIL</strong><div><a href="https://phabricator.kde.org/D16249">https://phabricator.kde.org/D16249</a></div></div><br /><div><strong>To: </strong>shubham, ngraham, elvisangelaccio, Frameworks<br /><strong>Cc: </strong>kde-frameworks-devel, michaelh, ngraham, bruns<br /></div>