D16111: use own extractor for testing the taglibwriter

Stefan BrĂ¼ns noreply at phabricator.kde.org
Wed Oct 10 19:45:11 BST 2018


bruns added inline comments.

INLINE COMMENTS

> taglibwritertest.cpp:5
>  #include "writedata.h"
> -
> +#include <kfilemetadata//ExtractorCollection>
> +#include <kfilemetadata//Extractor>

double slash

> taglibwritertest.cpp:56
> +    QCOMPARE(result.properties().value(Property::Album), QVariant(QStringLiteral("Album1") + stringSuffix));
> +    QCOMPARE(result.properties().value(Property::TrackNumber), QVariant(QStringLiteral("10")));
> +    QCOMPARE(result.properties().value(Property::ReleaseYear), QVariant(QStringLiteral("1999")));

IIRC TrackNumber and ReleaseYear are unsigned int, so this should be `value(prop).toInt()`, right?

REPOSITORY
  R286 KFileMetaData

REVISION DETAIL
  https://phabricator.kde.org/D16111

To: astippich, mgallien, bruns, svuorela
Cc: kde-frameworks-devel, #baloo, ashaposhnikov, michaelh, astippich, spoorun, ngraham, bruns, abrahams
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20181010/3aa94057/attachment-0001.html>


More information about the Kde-frameworks-devel mailing list