D16111: use own extractor for testing the taglibwriter

Alexander Stippich noreply at phabricator.kde.org
Wed Oct 10 18:36:57 BST 2018


astippich created this revision.
astippich added reviewers: mgallien, bruns, svuorela.
Herald added projects: Frameworks, Baloo.
Herald added subscribers: Baloo, kde-frameworks-devel.
astippich requested review of this revision.

REVISION SUMMARY
  Instead of querying the tags directly through taglib,
  use the taglibextractor to read the written tags for the tests.
  This will become useful once additional tags are added to the
  taglibwriter that require manual querying and reading.
  As a bonus, the now unneeded custom TString to QString function
  is removed.

TEST PLAN
  compiles and tests pass

REPOSITORY
  R286 KFileMetaData

BRANCH
  use_extractor_for_writertest

REVISION DETAIL
  https://phabricator.kde.org/D16111

AFFECTED FILES
  autotests/taglibwritertest.cpp

To: astippich, mgallien, bruns, svuorela
Cc: kde-frameworks-devel, #baloo, ashaposhnikov, michaelh, astippich, spoorun, ngraham, bruns, abrahams
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20181010/5560086f/attachment.html>


More information about the Kde-frameworks-devel mailing list