D15829: make units and prefixes of formatValue translatable
Alexander Stippich
noreply at phabricator.kde.org
Sun Oct 7 14:50:14 BST 2018
astippich added a comment.
In D15829#338296 <https://phabricator.kde.org/D15829#338296>, @safaalfulaij wrote:
> Thanks!
> I think this solved all my issues. I can for meter unit change the formatting so that `tr("%1 %2", "no Prefix")` is translated to `"%1%2"` and choose to keep the dot or remove it in the `unitString`s translation. (`"bit"` -> `".bit"`, `"m"` -> `"m"`)
> By the way, shouldn't that also be the case for English? I don't see people write `"1 m"` but `"1m"`, `"200 B"` but `"200B"`, same for `Hz`, not sure about `bit`s. The space is not there when abbreviation is used.
Great! Now looking forward to feedback from @bruns regarding the implementation :)
Scientifically it is correct to put a (small) space between value and unit.
REPOSITORY
R244 KCoreAddons
BRANCH
translate_units
REVISION DETAIL
https://phabricator.kde.org/D15829
To: astippich, bruns, safaalfulaij
Cc: kde-frameworks-devel, michaelh, ngraham, bruns
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20181007/ac1f65e3/attachment.html>
More information about the Kde-frameworks-devel
mailing list