D15912: Don't silently error if damage is sent before buffer

Roman Gilg noreply at phabricator.kde.org
Wed Oct 3 00:55:26 BST 2018


romangg requested changes to this revision.
romangg added inline comments.
This revision now requires changes to proceed.

INLINE COMMENTS

> surface_interface.cpp:461
>              }
> -        } else if (!target->buffer && emitChanged) {
> +        } else if (!target->buffer) {
>              subSurfaceIsMapped = false;

Unrelated change. Or split the whole case distinction directly up into:

  if (target->buffer) {
      if (!target->damage.isEmpty()) {
          ...
      }
  } else {
      subSurfaceIsMapped = false;
      emit q->unmapped();
  }

Maybe separate patch.

REPOSITORY
  R127 KWayland

REVISION DETAIL
  https://phabricator.kde.org/D15912

To: davidedmundson, #kwin, romangg
Cc: romangg, kde-frameworks-devel, michaelh, ngraham, bruns
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20181002/716ef99f/attachment-0001.html>


More information about the Kde-frameworks-devel mailing list