D15912: Don't silently error if damage is sent before buffer
David Edmundson
noreply at phabricator.kde.org
Wed Oct 3 00:41:11 BST 2018
davidedmundson created this revision.
davidedmundson added a reviewer: KWin.
Herald added a project: Frameworks.
Herald added a subscriber: kde-frameworks-devel.
davidedmundson requested review of this revision.
REVISION SUMMARY
Firefox sends
wl_surface at 37.damage(0, 0, 808, 622)
wl_surface at 37.attach(wl_buffer at 34, 0, 0)
Which we silently treat as an error.
There's nothing in the spec to forbid this. The only thing that matters
is the state on commit. This moves a check there.
CCBUG: 397834
TEST PLAN
Had a debug in there which was being activated
Gets firefox slightly further (but not complete)
REPOSITORY
R127 KWayland
BRANCH
master
REVISION DETAIL
https://phabricator.kde.org/D15912
AFFECTED FILES
src/server/surface_interface.cpp
To: davidedmundson, #kwin
Cc: kde-frameworks-devel, michaelh, ngraham, bruns
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20181002/029f59e4/attachment.html>
More information about the Kde-frameworks-devel
mailing list