D17185: Added ip-tunnel settings

Pranav Gade noreply at phabricator.kde.org
Wed Nov 28 08:08:52 GMT 2018


pranavgade marked 5 inline comments as done.
pranavgade added inline comments.

INLINE COMMENTS

> jgrulich wrote in iptunnelsettingtest.cpp:79
> Use NetworkManager defines, do not define your own new defines, there is no reason for that.

I tried to follow the way it is done in ipv6settings.

> jgrulich wrote in connectionsettings.cpp:195
> IpTunnel setting is not part of Tun connection, it should be completely separated connection type.

What should the new connection type be called?

> jgrulich wrote in iptunnelsetting.h:74
> Maybe turn this into QFlags?
> 
> See:
> typedef enum { /*< flags, prefix=NM_IP_TUNNEL_FLAG >*/
> 	NM_IP_TUNNEL_FLAG_NONE                           = 0x0,
> 	NM_IP_TUNNEL_FLAG_IP6_IGN_ENCAP_LIMIT            = 0x1,
> 	NM_IP_TUNNEL_FLAG_IP6_USE_ORIG_TCLASS            = 0x2,
> 	NM_IP_TUNNEL_FLAG_IP6_USE_ORIG_FLOWLABEL         = 0x4,
> 	NM_IP_TUNNEL_FLAG_IP6_MIP6_DEV                   = 0x8,
> 	NM_IP_TUNNEL_FLAG_IP6_RCV_DSCP_COPY              = 0x10,
> 	NM_IP_TUNNEL_FLAG_IP6_USE_ORIG_FWMARK            = 0x20,
> } NMIPTunnelFlags;

What do you mean? Should I create a new Enum?

REPOSITORY
  R282 NetworkManagerQt

REVISION DETAIL
  https://phabricator.kde.org/D17185

To: pranavgade, jgrulich
Cc: kde-frameworks-devel, michaelh, ngraham, bruns
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20181128/3600247f/attachment.html>


More information about the Kde-frameworks-devel mailing list