<table><tr><td style="">pranavgade marked 5 inline comments as done.<br />pranavgade added inline comments.
</td><a style="text-decoration: none; padding: 4px 8px; margin: 0 8px 8px; float: right; color: #464C5C; font-weight: bold; border-radius: 3px; background-color: #F7F7F9; background-image: linear-gradient(to bottom,#fff,#f1f0f1); display: inline-block; border: 1px solid rgba(71,87,120,.2);" href="https://phabricator.kde.org/D17185">View Revision</a></tr></table><br /><div><strong>INLINE COMMENTS</strong><div><div style="margin: 6px 0 12px 0;"><div style="border: 1px solid #C7CCD9; border-radius: 3px;"><div style="padding: 0; background: #F7F7F7; border-color: #e3e4e8; border-style: solid; border-width: 0 0 1px 0; margin: 0;"><div style="color: #74777d; background: #eff2f4; padding: 6px 8px; overflow: hidden;"><a style="float: right; text-decoration: none;" href="https://phabricator.kde.org/D17185#inline-93859">View Inline</a><span style="color: #4b4d51; font-weight: bold;">jgrulich</span> wrote in <span style="color: #4b4d51; font-weight: bold;">iptunnelsettingtest.cpp:79</span></div>
<div style="margin: 8px 0; padding: 0 12px; color: #74777D;"><p style="padding: 0; margin: 8px;">Use NetworkManager defines, do not define your own new defines, there is no reason for that.</p></div></div>
<div style="margin: 8px 0; padding: 0 12px;"><p style="padding: 0; margin: 8px;">I tried to follow the way it is done in ipv6settings.</p></div></div><br /><div style="border: 1px solid #C7CCD9; border-radius: 3px;"><div style="padding: 0; background: #F7F7F7; border-color: #e3e4e8; border-style: solid; border-width: 0 0 1px 0; margin: 0;"><div style="color: #74777d; background: #eff2f4; padding: 6px 8px; overflow: hidden;"><a style="float: right; text-decoration: none;" href="https://phabricator.kde.org/D17185#inline-93862">View Inline</a><span style="color: #4b4d51; font-weight: bold;">jgrulich</span> wrote in <span style="color: #4b4d51; font-weight: bold;">connectionsettings.cpp:195</span></div>
<div style="margin: 8px 0; padding: 0 12px; color: #74777D;"><p style="padding: 0; margin: 8px;">IpTunnel setting is not part of Tun connection, it should be completely separated connection type.</p></div></div>
<div style="margin: 8px 0; padding: 0 12px;"><p style="padding: 0; margin: 8px;">What should the new connection type be called?</p></div></div><br /><div style="border: 1px solid #C7CCD9; border-radius: 3px;"><div style="padding: 0; background: #F7F7F7; border-color: #e3e4e8; border-style: solid; border-width: 0 0 1px 0; margin: 0;"><div style="color: #74777d; background: #eff2f4; padding: 6px 8px; overflow: hidden;"><a style="float: right; text-decoration: none;" href="https://phabricator.kde.org/D17185#inline-93865">View Inline</a><span style="color: #4b4d51; font-weight: bold;">jgrulich</span> wrote in <span style="color: #4b4d51; font-weight: bold;">iptunnelsetting.h:74</span></div>
<div style="margin: 8px 0; padding: 0 12px; color: #74777D;"><p style="padding: 0; margin: 8px;">Maybe turn this into QFlags?</p>
<p style="padding: 0; margin: 8px;">See:<br />
typedef enum { /*< flags, prefix=NM_IP_TUNNEL_FLAG >*/<br />
NM_IP_TUNNEL_FLAG_NONE = 0x0,<br />
NM_IP_TUNNEL_FLAG_IP6_IGN_ENCAP_LIMIT = 0x1,<br />
NM_IP_TUNNEL_FLAG_IP6_USE_ORIG_TCLASS = 0x2,<br />
NM_IP_TUNNEL_FLAG_IP6_USE_ORIG_FLOWLABEL = 0x4,<br />
NM_IP_TUNNEL_FLAG_IP6_MIP6_DEV = 0x8,<br />
NM_IP_TUNNEL_FLAG_IP6_RCV_DSCP_COPY = 0x10,<br />
NM_IP_TUNNEL_FLAG_IP6_USE_ORIG_FWMARK = 0x20,<br />
} NMIPTunnelFlags;</p></div></div>
<div style="margin: 8px 0; padding: 0 12px;"><p style="padding: 0; margin: 8px;">What do you mean? Should I create a new Enum?</p></div></div></div></div></div><br /><div><strong>REPOSITORY</strong><div><div>R282 NetworkManagerQt</div></div></div><br /><div><strong>REVISION DETAIL</strong><div><a href="https://phabricator.kde.org/D17185">https://phabricator.kde.org/D17185</a></div></div><br /><div><strong>To: </strong>pranavgade, jgrulich<br /><strong>Cc: </strong>kde-frameworks-devel, michaelh, ngraham, bruns<br /></div>