D16801: Fix build on macOS
Harald Fernengel
noreply at phabricator.kde.org
Sat Nov 10 12:29:12 GMT 2018
harald created this revision.
Herald added a project: Frameworks.
Herald added a subscriber: kde-frameworks-devel.
harald requested review of this revision.
REVISION SUMMARY
On macOS, I'm getting the following error:
CMake Error at src/runtime/plugins/CMakeLists.txt:1 (if):
if given arguments:
"AND" "AND"
Unknown arguments specified
The reason is the double expansion of arguments in CMake, so instead of `if (${FOO})` one should write `if(FOO)`.
This patch fixes the build.
TEST PLAN
Running `cmake` on Mac OS X passes.
REPOSITORY
R268 KGlobalAccel
REVISION DETAIL
https://phabricator.kde.org/D16801
AFFECTED FILES
src/runtime/plugins/CMakeLists.txt
To: harald
Cc: kde-frameworks-devel, michaelh, ngraham, bruns
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20181110/f5bec841/attachment.html>
More information about the Kde-frameworks-devel
mailing list