D16593: [ExtractorCollection] Use only best matching extractor plugin

[Alexander Stippich]

astippich accepted this revision.
astippich added inline comments.
This revision is now accepted and ready to land.

INLINE COMMENTS

> bruns wrote in extractorcollection.cpp:163
> http://doc.qt.io/qt-5/qdebug.html#setAutoInsertSpaces is true by default.

I meant the code, not the output :)

> bruns wrote in extractorcollection.cpp:164
> > doesn't returning here cause immediate return after the first matching extractor for the mimetype has been found? that doesn't fit to the first paragraph of the summary.
> 
> Yes, and this is the intended change - best matching. We don't want text/plain if we have a better one.

That's what I figured, the summary was a little bit misleading.

REPOSITORY
  R286 KFileMetaData

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D16593

To: bruns, #frameworks, astippich
Cc: kde-frameworks-devel, #baloo, ashaposhnikov, michaelh, astippich, spoorun, ngraham, bruns, abrahams
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20181102/8f6f2714/attachment-0001.html>