D16593: [ExtractorCollection] Use only best matching extractor plugin

[Stefan Brüns]

bruns marked 2 inline comments as done.
bruns added inline comments.

INLINE COMMENTS

> astippich wrote in extractorcollection.cpp:163
> nitpick: extra space before "for"

http://doc.qt.io/qt-5/qdebug.html#setAutoInsertSpaces is true by default.

> astippich wrote in extractorcollection.cpp:164
> doesn't returning here cause immediate return after the first matching extractor for the mimetype has been found? that doesn't fit to the first paragraph of the summary.
> "Otherwise, all matches for all mime ancestors are returned, even if one plugin is a much better match than any other." sounds to me that all plugins of all ancestors are returned.

> doesn't returning here cause immediate return after the first matching extractor for the mimetype has been found? that doesn't fit to the first paragraph of the summary.

Yes, and this is the intended change - best matching. We don't want text/plain if we have a better one.

REPOSITORY
  R286 KFileMetaData

REVISION DETAIL
  https://phabricator.kde.org/D16593

To: bruns, #frameworks, astippich
Cc: kde-frameworks-devel, #baloo, ashaposhnikov, michaelh, astippich, spoorun, ngraham, bruns, abrahams
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20181102/ba44b3d5/attachment.html>