D16594: Add context to kcmodule connection to lambdas

David Edmundson noreply at phabricator.kde.org
Fri Nov 2 01:04:04 GMT 2018


davidedmundson added inline comments.

INLINE COMMENTS

> bruns wrote in kcmoduleqml.cpp:74
> `this` is desctructed after `d` has been deleted, so the signal may be still connected after d is deleted.
> 
> Does `disconnect(configModule, 0, this, 0)` work, when called in the destructor?

Technically yes, but there's no sane scope for a code path where configModule is emitting anything between deleting d and this.

REPOSITORY
  R295 KCMUtils

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D16594

To: davidedmundson, #plasma, broulik
Cc: bruns, kde-frameworks-devel, michaelh, ngraham
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20181102/3cadc199/attachment.html>


More information about the Kde-frameworks-devel mailing list