D16594: Add context to kcmodule connection to lambdas
Stefan BrĂ¼ns
noreply at phabricator.kde.org
Thu Nov 1 19:22:02 GMT 2018
bruns added inline comments.
INLINE COMMENTS
> kcmoduleqml.cpp:74
> setButtons((KCModule::Buttons)(int)d->configModule->buttons());
> - connect(configModule, &KQuickAddons::ConfigModule::buttonsChanged, [=] {
> + connect(configModule, &KQuickAddons::ConfigModule::buttonsChanged, this, [=] {
> setButtons((KCModule::Buttons)(int)d->configModule->buttons());
`this` is desctructed after `d` has been deleted, so the signal may be still connected after d is deleted.
Does `disconnect(configModule, 0, this, 0)` work, when called in the destructor?
REPOSITORY
R295 KCMUtils
BRANCH
master
REVISION DETAIL
https://phabricator.kde.org/D16594
To: davidedmundson, #plasma, broulik
Cc: bruns, kde-frameworks-devel, michaelh, ngraham
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20181101/3d3b48fd/attachment.html>
More information about the Kde-frameworks-devel
mailing list