D10410: Move the task of cleaning up of socket file to file ioslave and FdReceiver

Chinmoy Ranjan Pradhan noreply at phabricator.kde.org
Sun May 27 10:40:14 UTC 2018


chinmoyr added a comment.


  SocketAddress is used only in FdSender and FdRecevier.

INLINE COMMENTS

> ossi wrote in fdreceiver.cpp:57
> that's a good addition, but it isn't logically part of this patch, because it adds a new feature (cleanup at exit) instead of only refactoring.

So shall I commit this change separately right after pushing this patch? Or after all the related patches are pushed?

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D10410

To: chinmoyr, #frameworks, ossi, dfaure
Cc: kde-frameworks-devel, michaelh, ngraham, bruns
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20180527/d806c5b1/attachment-0001.html>


More information about the Kde-frameworks-devel mailing list