D10410: Move the task of cleaning up of socket file to file ioslave and FdReceiver

[Oswald Buddenhagen]

ossi requested changes to this revision.
ossi added a comment.
This revision now requires changes to proceed.


  did you make sure that this is the only place where SocketAddress is used?

INLINE COMMENTS

> fdreceiver.cpp:41
>      const SocketAddress addr(path.toStdString());
>      if (bind(m_socketDes, addr.address(), addr.length()) != 0 || listen(m_socketDes, 5) != 0) {
>          std::cerr << "bind/listen error:" << strerror(errno) << std::endl;

do the first unlink right before here, so it's equivalent with the old code, just better structured.

> fdreceiver.cpp:57
>      }
> +    ::unlink(m_path.toLocal8Bit().constData());
>  }

that's a good addition, but it isn't logically part of this patch, because it adds a new feature (cleanup at exit) instead of only refactoring.

> file_unix.cpp:87
>      const QString sockPath = socketPath();
> +    QFile::remove(sockPath);
>      FdReceiver fdRecv(sockPath);

that's the wrong place, imo. leave it FdReceiver, so it's more local.

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D10410

To: chinmoyr, #frameworks, ossi, dfaure
Cc: kde-frameworks-devel, michaelh, ngraham, bruns
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20180527/6f61386f/attachment.html>