D13037: [Dialog] Set PlasmaShellSurface on PlasmaShell being announced

[David Edmundson]

davidedmundson added a comment.


  This doesn't make sense (assuming everything else works correctly, which clearly isn't the case)
  
    registry->setup();
    connection->roundtrip();
  
  should mean the server will announce all the interfaces and we block all execution until we've processed it all.
  
  which means we "know" by the time we finish DialogShadows::Private::setupWaylandIntegration() we know plasmaShellAnnounced will have been emitted and that the plasmashell has been set. That's how it works in the regular case.
  
  roundTrip goes via the QPA, and that has been implemented in Kwin's QPA.

REPOSITORY
  R242 Plasma Framework (Library)

REVISION DETAIL
  https://phabricator.kde.org/D13037

To: romangg, #plasma
Cc: davidedmundson, kde-frameworks-devel, michaelh, ngraham, bruns
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20180522/41a2ccf4/attachment.html>