D12696: Use the new uds implementation

David Faure noreply at phabricator.kde.org
Tue May 8 12:03:42 UTC 2018


dfaure added inline comments.

INLINE COMMENTS

> udsentry.cpp:454
>  
> -KIOCORE_EXPORT QDebug operator<<(QDebug stream, const KIO::UDSEntry &entry)
> +KIOCORE_EXPORT QDataStream &operator<<(QDataStream &s, const UDSEntry &a)
>  {

Hmm why can't this be the friend function directly?

I don't like the added global functions in the public header...

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D12696

To: jtamate, dfaure, #frameworks
Cc: bruns, michaelh, ngraham
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20180508/63b89bbe/attachment.html>


More information about the Kde-frameworks-devel mailing list