D12388: Output device color curves correction

Vlad Zagorodniy noreply at phabricator.kde.org
Thu May 3 21:54:07 UTC 2018


zzag added a comment.


    const uint16_t *pos = (uint16_t*)array->data;
  
  Well, now you throw away const qualifiers. I think it should be something like this
  
    const uint16_t *pos = reinterpret_cast<const uint16_t*>(array->data);
  
  I suggest to get rid of C style casts because they aren't checked by the compiler.

REPOSITORY
  R127 KWayland

REVISION DETAIL
  https://phabricator.kde.org/D12388

To: romangg, #frameworks, davidedmundson, graesslin
Cc: graesslin, davidedmundson, zzag, cfeck, michaelh, bruns
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20180503/50e88664/attachment.html>


More information about the Kde-frameworks-devel mailing list