<table><tr><td style="">zzag added a comment.
</td><a style="text-decoration: none; padding: 4px 8px; margin: 0 8px 8px; float: right; color: #464C5C; font-weight: bold; border-radius: 3px; background-color: #F7F7F9; background-image: linear-gradient(to bottom,#fff,#f1f0f1); display: inline-block; border: 1px solid rgba(71,87,120,.2);" href="https://phabricator.kde.org/D12388">View Revision</a></tr></table><br /><div><div><div class="remarkup-code-block" style="margin: 12px 0;" data-code-lang="cpp" data-sigil="remarkup-code-block"><pre class="remarkup-code" style="font: 11px/15px "Menlo", "Consolas", "Monaco", monospace; padding: 12px; margin: 0; background: rgba(71, 87, 120, 0.08);"><span style="color: #aa4000">const</span> <span style="color: #aa4000">uint16_t</span> <span style="color: #aa2211">*</span><span class="n">pos</span> <span style="color: #aa2211">=</span> <span class="p">(</span><span style="color: #aa4000">uint16_t</span><span style="color: #aa2211">*</span><span class="p">)</span><span class="n">array</span><span style="color: #aa2211">-></span><span class="n">data</span><span class="p">;</span></pre></div>

<p>Well, now you throw away const qualifiers. I think it should be something like this</p>

<div class="remarkup-code-block" style="margin: 12px 0;" data-code-lang="cpp" data-sigil="remarkup-code-block"><pre class="remarkup-code" style="font: 11px/15px "Menlo", "Consolas", "Monaco", monospace; padding: 12px; margin: 0; background: rgba(71, 87, 120, 0.08);"><span style="color: #aa4000">const</span> <span style="color: #aa4000">uint16_t</span> <span style="color: #aa2211">*</span><span class="n">pos</span> <span style="color: #aa2211">=</span> <span style="color: #aa4000">reinterpret_cast</span><span style="color: #aa2211"><</span><span style="color: #aa4000">const</span> <span style="color: #aa4000">uint16_t</span><span style="color: #aa2211">*></span><span class="p">(</span><span class="n">array</span><span style="color: #aa2211">-></span><span class="n">data</span><span class="p">);</span></pre></div>

<p>I suggest to get rid of C style casts because they aren't checked by the compiler.</p></div></div><br /><div><strong>REPOSITORY</strong><div><div>R127 KWayland</div></div></div><br /><div><strong>REVISION DETAIL</strong><div><a href="https://phabricator.kde.org/D12388">https://phabricator.kde.org/D12388</a></div></div><br /><div><strong>To: </strong>romangg, Frameworks, davidedmundson, graesslin<br /><strong>Cc: </strong>graesslin, davidedmundson, zzag, cfeck, michaelh, bruns<br /></div>