D12320: {RFC] add ability to read embedded cover files

[Stefan Brüns]

bruns added inline comments.

INLINE COMMENTS

> embeddedimagedata.h:36
> +    };
> +    QByteArray imageData(const QString &fileUrl, const QMimeDatabase &mimeDatabase, const ImageType imageType = FrontCover) const;
> +

return type QMap<ImageType, QByteArray>?

And instead of an enum imageType a QFlags<ImageType> imagetype?

The mimeDatabase should not be part of the method signature, its an implementation detail

REPOSITORY
  R286 KFileMetaData

REVISION DETAIL
  https://phabricator.kde.org/D12320

To: astippich, mgallien, michaelh
Cc: bruns, #frameworks, ashaposhnikov, michaelh, astippich, spoorun
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20180501/c60593c2/attachment.html>