D11183: Sonnet: don't impose the default client

[David Faure]

dfaure requested changes to this revision.
dfaure added a comment.
This revision now requires changes to proceed.


  I suggested find_if because I didn't think about any_of, which is even better indeed :-)
  If I suggest something and Milian suggests something else then Milian is right :-)

INLINE COMMENTS

> loader.cpp:114
>          Client *item = itr.next();
>          if (!backend.isEmpty()) {
>              if (backend == item->name()) {

can this ever happen now that you set it if it was empty? If it can happen (because defaultClient() can return empty) then the any_of block needs an if (!backend.isEmpty()) around it.

REPOSITORY
  R246 Sonnet

REVISION DETAIL
  https://phabricator.kde.org/D11183

To: rjvbb, #frameworks, cullmann, dfaure, mlaurent, vkrause
Cc: mwolff, kde-frameworks-devel, michaelh, ngraham
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20180326/3d09f42b/attachment.html>