D11346: Only set iconText() if actually changed

Christoph Feck noreply at phabricator.kde.org
Thu Mar 15 13:27:50 UTC 2018


cfeck added inline comments.

INLINE COMMENTS

> apol wrote in kacceleratormanager.cpp:792
> What happens when iconText.isEmpty()?

Qt returns QAction::text() when QAction::iconText() is empty. Apparently Qt also strips some text, so to check if there was no iconText(), we need this weird check instead of using isEmpty().

REPOSITORY
  R236 KWidgetsAddons

REVISION DETAIL
  https://phabricator.kde.org/D11346

To: cfeck, #frameworks, chehrlic
Cc: apol, chehrlic, michaelh, ngraham
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20180315/d0c91763/attachment.html>


More information about the Kde-frameworks-devel mailing list