D11346: Only set iconText() if actually changed

Aleix Pol Gonzalez noreply at phabricator.kde.org
Thu Mar 15 11:39:07 UTC 2018


apol added inline comments.

INLINE COMMENTS

> kacceleratormanager.cpp:792
>          // Check if iconText was generated by Qt. In that case ignore it (no support for CJK accelerators) and set it from the text.
>          if (iconText == copy_of_qt_strippedText(oldText)) {
>              iconText = removeAcceleratorMarker(oldText);

What happens when iconText.isEmpty()?

REPOSITORY
  R236 KWidgetsAddons

REVISION DETAIL
  https://phabricator.kde.org/D11346

To: cfeck, #frameworks, chehrlic
Cc: apol, chehrlic, michaelh, ngraham
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20180315/53a68461/attachment-0001.html>


More information about the Kde-frameworks-devel mailing list