D11279: [FileIndexerConfig] Delay populating folders until actually used

[Kai Uwe Broulik]

broulik created this revision.
broulik added a reviewer: michaelh.
Restricted Application added projects: Frameworks, Baloo.
Restricted Application added a subscriber: Frameworks.
broulik requested review of this revision.

REVISION SUMMARY
  The folder inclusion/exclusion configuration queries Solid for external media to exclude them, this adds a significant overhead to using FileIndexerConfig.
  In most places it is merely used to check whether file indexing is enabled in general.

TEST PLAN
  Creating `DolphinViewActionHandler` which checks Baloo availability on Dolphin startup showed up as 3% cost in the profiler. After this change it is less than 0.4%.
  
  - Verified that Baloo file places disappeared when disabling it
  - Verified that Dolphin search still enabled and disabled additional search criteria depending on the folder you're searching in and that it is using `baloosearch` or `filenamesearch` accordingly; also verified that the folder cache is populated when this happens
  
  Dolphin does not gray out sort options and additional roles for Baloo roles when disabled but that is a bug unrelated to this change

REPOSITORY
  R293 Baloo

REVISION DETAIL
  https://phabricator.kde.org/D11279

AFFECTED FILES
  src/file/fileindexerconfig.cpp
  src/file/fileindexerconfig.h

To: broulik, michaelh
Cc: #frameworks, ashaposhnikov, michaelh, spoorun, nicolasfella, alexeymin
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20180313/83777f87/attachment.html>