D10621: Highlighting Indexer: list of suggestions

[Dominik Haumann]

dhaumann requested changes to this revision.
dhaumann added a comment.
This revision now requires changes to proceed.


  Btw, current generated list finds 1658 issues: https://paste.kde.org/p7iareuxc
  
  Not all of them are correct, for instance
  
    zsh.xml" line 919 RegExpr candidate for  "Detect2Chars" : "%1"
  
  I believe %1 in this case is a backreference in a dynamic context, so a change to Detect2Chars would be wrong.
  
  Similarly, the suggestion
  
    html-php.xml" line 223 RegExpr candidate for  "AnyChar" : "[^/><\"'\\s]"
  
  is also not correct, since [^xyz] means match everything _except_ xyz, so the ^ symbol negates this, afaik (or am I remembering incorrectly?)...
  
  Still, there are many valid items which certainly can be optimized. So patches for fixes welcome! In small chunks, if possible!

REPOSITORY
  R216 Syntax Highlighting

REVISION DETAIL
  https://phabricator.kde.org/D10621

To: jpoelen, dhaumann
Cc: #framework_syntax_highlighting, dhaumann, #frameworks, michaelh, genethomas, cullmann, vkrause
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20180310/7d2f6c26/attachment.html>