D10776: Make it possible to generate po files in parallel

[Harald Sitter]

sitter added a comment.


  Ingenious code!
  
  You left some debug clutter behind though.
  
  Also, the if i statement is inconsistent between the two files
  
  `    if (i EQUAL ${numberOfProcesses})` vs. `    if (i GREATER ${numberOfProcesses})`

INLINE COMMENTS

> build-pofiles.cmake:45
> +    )
> +    if(code)
> +        message(FATAL_ERROR "failed generating ${PO_DIR}")

I think `!(code EQUAL 0)` may be more explicit here.

> build-pofiles.cmake:62
> +    math(EXPR i "${i}+1")
> +    message(STATUS "::: ${i}")
> +    if (i EQUAL ${numberOfProcesses})

debug

> build-pofiles.cmake:63
> +    message(STATUS "::: ${i}")
> +    if (i EQUAL ${numberOfProcesses})
> +        message(STATUS "holt")

no space after if.

> build-pofiles.cmake:64
> +    if (i EQUAL ${numberOfProcesses})
> +        message(STATUS "holt")
> +        _processCommands()

debug

REPOSITORY
  R249 KI18n

REVISION DETAIL
  https://phabricator.kde.org/D10776

To: apol, #frameworks, sitter
Cc: michaelh
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20180306/954a109c/attachment.html>