<table><tr><td style="">sitter added a comment.
</td><a style="text-decoration: none; padding: 4px 8px; margin: 0 8px 8px; float: right; color: #464C5C; font-weight: bold; border-radius: 3px; background-color: #F7F7F9; background-image: linear-gradient(to bottom,#fff,#f1f0f1); display: inline-block; border: 1px solid rgba(71,87,120,.2);" href="https://phabricator.kde.org/D10776">View Revision</a></tr></table><br /><div><div><p>Ingenious code!</p>

<p>You left some debug clutter behind though.</p>

<p>Also, the if i statement is inconsistent between the two files</p>

<p><tt style="background: #ebebeb; font-size: 13px;">    if (i EQUAL ${numberOfProcesses})</tt> vs. <tt style="background: #ebebeb; font-size: 13px;">    if (i GREATER ${numberOfProcesses})</tt></p></div></div><br /><div><strong>INLINE COMMENTS</strong><div><div style="margin: 6px 0 12px 0;"><div style="border: 1px solid #C7CCD9; border-radius: 3px;"><div style="padding: 0; background: #F7F7F7; border-color: #e3e4e8; border-style: solid; border-width: 0 0 1px 0; margin: 0;"><div style="color: #74777d; background: #eff2f4; padding: 6px 8px; overflow: hidden;"><a style="float: right; text-decoration: none;" href="https://phabricator.kde.org/D10776#inline-53639">View Inline</a><span style="color: #4b4d51; font-weight: bold;">build-pofiles.cmake:45</span></div>
<div style="font: 11px/15px "Menlo", "Consolas", "Monaco", monospace; white-space: pre-wrap; clear: both; padding: 4px 0; margin: 0;"><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);">    <span class="p">)</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);">    <span style="color: #304a96">if</span><span class="p">(</span><span style="color: #766510">code</span><span class="p">)</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);">        <span style="color: #304a96">message</span><span class="p">(</span><span style="color: #766510">FATAL_ERROR</span> <span style="color: #766510">"failed generating ${PO_DIR}"</span><span class="p">)</span>
</div></div></div>
<div style="margin: 8px 0; padding: 0 12px;"><p style="padding: 0; margin: 8px;">I think <tt style="background: #ebebeb; font-size: 13px;">!(code EQUAL 0)</tt> may be more explicit here.</p></div></div><br /><div style="border: 1px solid #C7CCD9; border-radius: 3px;"><div style="padding: 0; background: #F7F7F7; border-color: #e3e4e8; border-style: solid; border-width: 0 0 1px 0; margin: 0;"><div style="color: #74777d; background: #eff2f4; padding: 6px 8px; overflow: hidden;"><a style="float: right; text-decoration: none;" href="https://phabricator.kde.org/D10776#inline-53635">View Inline</a><span style="color: #4b4d51; font-weight: bold;">build-pofiles.cmake:62</span></div>
<div style="font: 11px/15px "Menlo", "Consolas", "Monaco", monospace; white-space: pre-wrap; clear: both; padding: 4px 0; margin: 0;"><div style="padding: 0 8px; margin: 0 4px; background: rgba(251, 175, 175, .7);">    <span class="bright"></span><span style="color: #304a96"><span class="bright">execute_process</span></span><span class="bright"></span><span class="p"><span class="bright">(</span></span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(251, 175, 175, .7);">    <span class="bright">    </span><span style="color: #766510"><span class="bright">COMMAND</span></span><span class="bright"> </span><span style="color: #aa2211"><span class="bright">${</span></span><span class="bright"></span><span style="color: #001294"><span class="bright">GETTEXT_MSGFMT_EXECUTABLE</span></span><span class="bright"></span><span style="color: #aa2211"><span class="bright">}</span></span><span class="bright"> </span><span style="color: #766510"><span class="bright">-o</span></span><span class="bright"> </span><span style="color: #aa2211"><span class="bright">${</span></span><span class="bright"></span><span style="color: #001294"><span class="bright">dest</span></span><span class="bright"></span><span style="color: #aa2211"><span class="bright">}</span></span><span class="bright"></span><span style="color: #766510"><span class="bright">/</span></span><span class="bright"></span><span style="color: #aa2211"><span class="bright">${</span></span><span class="bright"></span><span style="color: #001294"><span class="bright">name</span></span><span class="bright"></span><span style="color: #aa2211"><span class="bright">}</span></span><span class="bright"></span><span style="color: #766510"><span class="bright">.mo</span></span><span class="bright"> </span><span style="color: #aa2211"><span class="bright">${</span></span><span class="bright"></span><span style="color: #001294"><span class="bright">PO_DIR</span></span><span class="bright"></span><span style="color: #aa2211"><span class="bright">}</span></span><span class="bright"></span><span style="color: #766510"><span class="bright">/</span></span><span class="bright"></span><span style="color: #aa2211"><span class="bright">${</span></span><span class="bright"></span><span style="color: #001294"><span class="bright">pofile</span></span><span class="bright"></span><span style="color: #aa2211"><span class="bright">}</span></span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(251, 175, 175, .7);">    <span class="bright">    </span><span style="color: #766510"><span class="bright">RESULT_VARIABLE</span></span><span class="bright"> </span><span style="color: #766510"><span class="bright">code</span></span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);">    <span class="bright"></span><span style="color: #304a96"><span class="bright">math</span></span><span class="bright"></span><span class="p"><span class="bright">(</span></span><span class="bright"></span><span style="color: #766510"><span class="bright">EXPR</span></span><span class="bright"> </span><span style="color: #766510"><span class="bright">i</span></span><span class="bright"> </span><span style="color: #766510"><span class="bright">"${i}+1"</span></span><span class="bright"></span><span class="p"><span class="bright">)</span></span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);">    <span class="bright"></span><span style="color: #304a96"><span class="bright">message</span></span><span class="bright"></span><span class="p"><span class="bright">(</span></span><span class="bright"></span><span style="color: #766510"><span class="bright">STATUS</span></span><span class="bright"> </span><span style="color: #766510"><span class="bright">"::: ${i}"</span></span><span class="bright"></span><span class="p"><span class="bright">)</span></span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);">    <span class="bright"></span><span style="color: #304a96"><span class="bright">if</span></span><span class="bright"> </span><span class="p"><span class="bright">(</span></span><span class="bright"></span><span style="color: #766510"><span class="bright">i</span></span><span class="bright"> </span><span style="color: #766510"><span class="bright">EQUAL</span></span><span class="bright"> </span><span style="color: #aa2211"><span class="bright">${</span></span><span class="bright"></span><span style="color: #001294"><span class="bright">numberOfProcesses</span></span><span class="bright"></span><span style="color: #aa2211"><span class="bright">}</span></span><span class="bright"></span><span class="p"><span class="bright">)</span></span>
</div></div></div>
<div style="margin: 8px 0; padding: 0 12px;"><p style="padding: 0; margin: 8px;">debug</p></div></div><br /><div style="border: 1px solid #C7CCD9; border-radius: 3px;"><div style="padding: 0; background: #F7F7F7; border-color: #e3e4e8; border-style: solid; border-width: 0 0 1px 0; margin: 0;"><div style="color: #74777d; background: #eff2f4; padding: 6px 8px; overflow: hidden;"><a style="float: right; text-decoration: none;" href="https://phabricator.kde.org/D10776#inline-53637">View Inline</a><span style="color: #4b4d51; font-weight: bold;">build-pofiles.cmake:63</span></div>
<div style="font: 11px/15px "Menlo", "Consolas", "Monaco", monospace; white-space: pre-wrap; clear: both; padding: 4px 0; margin: 0;"><div style="padding: 0 8px; margin: 0 4px; background: rgba(251, 175, 175, .7);">    <span class="bright">    </span><span style="color: #766510"><span class="bright">COMMAND</span></span><span class="bright"> </span><span style="color: #aa2211"><span class="bright">${</span></span><span class="bright"></span><span style="color: #001294"><span class="bright">GETTEXT_MSGFMT_EXECUTABLE</span></span><span class="bright"></span><span style="color: #aa2211"><span class="bright">}</span></span><span class="bright"> </span><span style="color: #766510"><span class="bright">-o</span></span><span class="bright"> </span><span style="color: #aa2211"><span class="bright">${</span></span><span class="bright"></span><span style="color: #001294"><span class="bright">dest</span></span><span class="bright"></span><span style="color: #aa2211"><span class="bright">}</span></span><span class="bright"></span><span style="color: #766510"><span class="bright">/</span></span><span class="bright"></span><span style="color: #aa2211"><span class="bright">${</span></span><span class="bright"></span><span style="color: #001294"><span class="bright">name</span></span><span class="bright"></span><span style="color: #aa2211"><span class="bright">}</span></span><span class="bright"></span><span style="color: #766510"><span class="bright">.mo</span></span><span class="bright"> </span><span style="color: #aa2211"><span class="bright">${</span></span><span class="bright"></span><span style="color: #001294"><span class="bright">PO_DIR</span></span><span class="bright"></span><span style="color: #aa2211"><span class="bright">}</span></span><span class="bright"></span><span style="color: #766510"><span class="bright">/</span></span><span class="bright"></span><span style="color: #aa2211"><span class="bright">${</span></span><span class="bright"></span><span style="color: #001294"><span class="bright">pofile</span></span><span class="bright"></span><span style="color: #aa2211"><span class="bright">}</span></span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(251, 175, 175, .7);">    <span class="bright">    </span><span style="color: #766510"><span class="bright">RESULT_VARIABLE</span></span><span class="bright"> </span><span style="color: #766510"><span class="bright">code</span></span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(251, 175, 175, .7);">    <span class="p">)</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);">    <span class="bright"></span><span style="color: #304a96"><span class="bright">message</span></span><span class="bright"></span><span class="p"><span class="bright">(</span></span><span class="bright"></span><span style="color: #766510"><span class="bright">STATUS</span></span><span class="bright"> </span><span style="color: #766510"><span class="bright">"::: ${i}"</span></span><span class="bright"></span><span class="p"><span class="bright">)</span></span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);">    <span class="bright"></span><span style="color: #304a96"><span class="bright">if</span></span><span class="bright"> </span><span class="p"><span class="bright">(</span></span><span class="bright"></span><span style="color: #766510"><span class="bright">i</span></span><span class="bright"> </span><span style="color: #766510"><span class="bright">EQUAL</span></span><span class="bright"> </span><span style="color: #aa2211"><span class="bright">${</span></span><span class="bright"></span><span style="color: #001294"><span class="bright">numberOfProcesses</span></span><span class="bright"></span><span style="color: #aa2211"><span class="bright">}</span></span><span class="bright"></span><span class="p"><span class="bright">)</span></span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);">    <span class="bright">    </span><span style="color: #304a96"><span class="bright">message</span></span><span class="bright"></span><span class="p"><span class="bright">(</span></span><span class="bright"></span><span style="color: #766510"><span class="bright">STATUS</span></span><span class="bright"> </span><span style="color: #766510"><span class="bright">"holt"</span></span><span class="p">)</span>
</div></div></div>
<div style="margin: 8px 0; padding: 0 12px;"><p style="padding: 0; margin: 8px;">no space after if.</p></div></div><br /><div style="border: 1px solid #C7CCD9; border-radius: 3px;"><div style="padding: 0; background: #F7F7F7; border-color: #e3e4e8; border-style: solid; border-width: 0 0 1px 0; margin: 0;"><div style="color: #74777d; background: #eff2f4; padding: 6px 8px; overflow: hidden;"><a style="float: right; text-decoration: none;" href="https://phabricator.kde.org/D10776#inline-53636">View Inline</a><span style="color: #4b4d51; font-weight: bold;">build-pofiles.cmake:64</span></div>
<div style="font: 11px/15px "Menlo", "Consolas", "Monaco", monospace; white-space: pre-wrap; clear: both; padding: 4px 0; margin: 0;"><div style="padding: 0 8px; margin: 0 4px; background: rgba(251, 175, 175, .7);">    <span class="bright">    </span><span style="color: #766510"><span class="bright">RESULT_VARIABLE</span></span><span class="bright"> </span><span style="color: #766510"><span class="bright">code</span></span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(251, 175, 175, .7);">    <span class="p">)</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(251, 175, 175, .7);">    <span class="bright"></span><span style="color: #304a96"><span class="bright">if</span></span><span class="bright"></span><span class="p"><span class="bright">(</span></span><span class="bright"></span><span style="color: #766510"><span class="bright">code</span></span><span class="p">)</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);">    <span class="bright"></span><span style="color: #304a96"><span class="bright">if</span></span><span class="bright"> </span><span class="p"><span class="bright">(</span></span><span class="bright"></span><span style="color: #766510"><span class="bright">i</span></span><span class="bright"> </span><span style="color: #766510"><span class="bright">EQUAL</span></span><span class="bright"> </span><span style="color: #aa2211"><span class="bright">${</span></span><span class="bright"></span><span style="color: #001294"><span class="bright">numberOfProcesses</span></span><span class="bright"></span><span style="color: #aa2211"><span class="bright">}</span></span><span class="bright"></span><span class="p"><span class="bright">)</span></span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);">    <span class="bright">    </span><span style="color: #304a96"><span class="bright">message</span></span><span class="bright"></span><span class="p"><span class="bright">(</span></span><span class="bright"></span><span style="color: #766510"><span class="bright">STATUS</span></span><span class="bright"> </span><span style="color: #766510"><span class="bright">"holt"</span></span><span class="p">)</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);">    <span class="bright">    </span><span style="color: #304a96"><span class="bright">_processCommands</span></span><span class="bright"></span><span class="p"><span class="bright">(</span>)</span>
</div></div></div>
<div style="margin: 8px 0; padding: 0 12px;"><p style="padding: 0; margin: 8px;">debug</p></div></div></div></div></div><br /><div><strong>REPOSITORY</strong><div><div>R249 KI18n</div></div></div><br /><div><strong>REVISION DETAIL</strong><div><a href="https://phabricator.kde.org/D10776">https://phabricator.kde.org/D10776</a></div></div><br /><div><strong>To: </strong>apol, Frameworks, sitter<br /><strong>Cc: </strong>michaelh<br /></div>