D13777: KMessageWidget : revert to using highlight colour for Information style (WIP)

Christoph Feck noreply at phabricator.kde.org
Thu Jun 28 19:13:04 UTC 2018


cfeck added inline comments.

INLINE COMMENTS

> kmessagewidget.cpp:263
> +    QStringList rgb = settings->value(key).toStringList();
> +    return QColor(rgb.at(0).toInt(), rgb.at(1).toInt(), rgb.at(2).toInt());
> +}

missing `if (rgb.size() >= 3)`

> kmessagewidget.cpp:281
> +    const QString themeGroup = QStringLiteral("Colors:Window");
> +    QSettings *settings = !kdeGlobals.isEmpty()? new QSettings(kdeGlobals, QSettings::IniFormat) : nullptr;
> +    if (settings && settings->childGroups().contains(themeGroup)) {

missing space before `?`

REPOSITORY
  R236 KWidgetsAddons

REVISION DETAIL
  https://phabricator.kde.org/D13777

To: rjvbb, ngraham, #frameworks
Cc: cfeck, kde-frameworks-devel, michaelh, ngraham, bruns
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20180628/2a3a6d5b/attachment.html>


More information about the Kde-frameworks-devel mailing list