D13641: [KCharSelect] Port generate-datafile.py to Python 3

Luca Beltrame noreply at phabricator.kde.org
Fri Jun 22 04:43:54 UTC 2018


lbeltrame requested changes to this revision.
lbeltrame added inline comments.
This revision now requires changes to proceed.

INLINE COMMENTS

> kcharselect-generate-datafile.py:41


Perhaps the diff view is wrong.. but the `return size` here (at this level of nesting) wouldn't make the downstream code de facto unreachable in this function?

> kcharselect-generate-datafile.py:118


Same here.

REPOSITORY
  R236 KWidgetsAddons

REVISION DETAIL
  https://phabricator.kde.org/D13641

To: cfeck, #frameworks, lbeltrame
Cc: kde-frameworks-devel, michaelh, ngraham, bruns
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20180622/8fb9b3e6/attachment.html>


More information about the Kde-frameworks-devel mailing list