D13502: Fix compiler warning about hidden virtual overloads

[Vlad Zagorodniy]

zzag added a comment.


  > Compiles with no warnings \o/
  
  Nope.
  
    In file included from /home/vlad/KDE/src/frameworks/kwayland/src/client/xdgshell_v6.cpp:20:
    /home/vlad/KDE/src/frameworks/kwayland/src/client/xdgshell_p.h:49:13: warning: ‘virtual KWayland::Client::XdgShell::Private::operator xdg_shell*() const’ was hidden [-Woverloaded-virtual]
         virtual operator xdg_shell*() const {
                 ^~~~~~~~
    <built-in>: warning:   by ‘operator’ [-Woverloaded-virtual]
    /home/vlad/KDE/src/frameworks/kwayland/src/client/xdgshell_p.h:46:13: warning: ‘virtual KWayland::Client::XdgShell::Private::operator xdg_shell*()’ was hidden [-Woverloaded-virtual]
         virtual operator xdg_shell*() {
                 ^~~~~~~~
    <built-in>: warning:   by ‘operator’ [-Woverloaded-virtual]
    /home/vlad/KDE/src/frameworks/kwayland/src/client/xdgshell_p.h:60:28: warning: ‘virtual KWayland::Client::XdgShellPopup* KWayland::Client::XdgShell::Private::getXdgPopup(KWayland::Client::Surface*, KWayland::Client::Surface*, KWayland::Client::Seat*, quint32, const QPoint&, QObject*)’ was hidden [-Woverloaded-virtual]
         virtual XdgShellPopup *getXdgPopup(Surface *surface, Surface *parentSurface, Seat *seat, quint32 serial, const QPoint &parentPos, QObject *parent) {
                                ^~~~~~~~~~~
    /home/vlad/KDE/src/frameworks/kwayland/src/client/xdgshell_v6.cpp:45:20: warning:   by ‘KWayland::Client::XdgShellUnstableV6::Private::getXdgPopup’ [-Woverloaded-virtual]
         XdgShellPopup *getXdgPopup(Surface *surface, XdgShellPopup *parentSurface, const XdgPositioner &positioner, QObject *parent) override;
                        ^~~~~~~~~~~
    In file included from /home/vlad/KDE/src/frameworks/kwayland/src/client/xdgshell_v6.cpp:20:
    /home/vlad/KDE/src/frameworks/kwayland/src/client/xdgshell_p.h:163:13: warning: ‘virtual KWayland::Client::XdgShellSurface::Private::operator xdg_surface*() const’ was hidden [-Woverloaded-virtual]
         virtual operator xdg_surface*() const {
                 ^~~~~~~~
    <built-in>: warning:   by ‘operator’ [-Woverloaded-virtual]
    /home/vlad/KDE/src/frameworks/kwayland/src/client/xdgshell_p.h:160:13: warning: ‘virtual KWayland::Client::XdgShellSurface::Private::operator xdg_surface*()’ was hidden [-Woverloaded-virtual]
         virtual operator xdg_surface*() {
                 ^~~~~~~~
    <built-in>: warning:   by ‘operator’ [-Woverloaded-virtual]
    /home/vlad/KDE/src/frameworks/kwayland/src/client/xdgshell_p.h:225:13: warning: ‘virtual KWayland::Client::XdgShellPopup::Private::operator xdg_popup*() const’ was hidden [-Woverloaded-virtual]
         virtual operator xdg_popup*() const {
                 ^~~~~~~~
    <built-in>: warning:   by ‘operator’ [-Woverloaded-virtual]
    /home/vlad/KDE/src/frameworks/kwayland/src/client/xdgshell_p.h:222:13: warning: ‘virtual KWayland::Client::XdgShellPopup::Private::operator xdg_popup*()’ was hidden [-Woverloaded-virtual]
         virtual operator xdg_popup*() {
                 ^~~~~~~~
    <built-in>: warning:   by ‘operator’ [-Woverloaded-virtual]
    
    In file included from /home/vlad/KDE/src/frameworks/kwayland/src/client/xdgshell_v5.cpp:20:
    /home/vlad/KDE/src/frameworks/kwayland/src/client/xdgshell_p.h:55:13: warning: ‘virtual KWayland::Client::XdgShell::Private::operator zxdg_shell_v6*() const’ was hidden [-Woverloaded-virtual]
         virtual operator zxdg_shell_v6*() const {
                 ^~~~~~~~
    <built-in>: warning:   by ‘operator’ [-Woverloaded-virtual]
    /home/vlad/KDE/src/frameworks/kwayland/src/client/xdgshell_p.h:52:13: warning: ‘virtual KWayland::Client::XdgShell::Private::operator zxdg_shell_v6*()’ was hidden [-Woverloaded-virtual]
         virtual operator zxdg_shell_v6*() {
                 ^~~~~~~~
    <built-in>: warning:   by ‘operator’ [-Woverloaded-virtual]
    In file included from /home/vlad/KDE/src/frameworks/kwayland/src/client/xdgshell_v5.cpp:20:
    /home/vlad/KDE/src/frameworks/kwayland/src/client/xdgshell_p.h:80:28: warning: ‘virtual KWayland::Client::XdgShellPopup* KWayland::Client::XdgShell::Private::getXdgPopup(KWayland::Client::Surface*, KWayland::Client::XdgShellPopup*, const KWayland::Client::XdgPositioner&, QObject*)’ was hidden [-Woverloaded-virtual]
         virtual XdgShellPopup *getXdgPopup(Surface *surface, XdgShellPopup *parentSurface, const XdgPositioner &positioner, QObject *parent) {
                                ^~~~~~~~~~~
    /home/vlad/KDE/src/frameworks/kwayland/src/client/xdgshell_v5.cpp:41:20: warning:   by ‘virtual KWayland::Client::XdgShellPopup* KWayland::Client::XdgShellUnstableV5::Private::getXdgPopup(KWayland::Client::Surface*, KWayland::Client::Surface*, KWayland::Client::Seat*, quint32, const QPoint&, QObject*)’ [-Woverloaded-virtual]
         XdgShellPopup *getXdgPopup(Surface *surface, Surface *parentSurface, Seat *seat, quint32 serial, const QPoint &parentPos, QObject *parent) override;
                        ^~~~~~~~~~~
    In file included from /home/vlad/KDE/src/frameworks/kwayland/src/client/xdgshell_v5.cpp:20:
    /home/vlad/KDE/src/frameworks/kwayland/src/client/xdgshell_p.h:71:28: warning: ‘virtual KWayland::Client::XdgShellPopup* KWayland::Client::XdgShell::Private::getXdgPopup(KWayland::Client::Surface*, KWayland::Client::XdgShellSurface*, const KWayland::Client::XdgPositioner&, QObject*)’ was hidden [-Woverloaded-virtual]
         virtual XdgShellPopup *getXdgPopup(Surface *surface, XdgShellSurface *parentSurface, const XdgPositioner &positioner, QObject *parent) {
                                ^~~~~~~~~~~
    /home/vlad/KDE/src/frameworks/kwayland/src/client/xdgshell_v5.cpp:41:20: warning:   by ‘virtual KWayland::Client::XdgShellPopup* KWayland::Client::XdgShellUnstableV5::Private::getXdgPopup(KWayland::Client::Surface*, KWayland::Client::Surface*, KWayland::Client::Seat*, quint32, const QPoint&, QObject*)’ [-Woverloaded-virtual]
         XdgShellPopup *getXdgPopup(Surface *surface, Surface *parentSurface, Seat *seat, quint32 serial, const QPoint &parentPos, QObject *parent) override;
                        ^~~~~~~~~~~
    In file included from /home/vlad/KDE/src/frameworks/kwayland/src/client/xdgshell_v5.cpp:20:
    /home/vlad/KDE/src/frameworks/kwayland/src/client/xdgshell_p.h:175:13: warning: ‘virtual KWayland::Client::XdgShellSurface::Private::operator zxdg_toplevel_v6*() const’ was hidden [-Woverloaded-virtual]
         virtual operator zxdg_toplevel_v6*() const {
                 ^~~~~~~~
    <built-in>: warning:   by ‘operator’ [-Woverloaded-virtual]
    /home/vlad/KDE/src/frameworks/kwayland/src/client/xdgshell_p.h:172:13: warning: ‘virtual KWayland::Client::XdgShellSurface::Private::operator zxdg_toplevel_v6*()’ was hidden [-Woverloaded-virtual]
         virtual operator zxdg_toplevel_v6*() {
                 ^~~~~~~~
    <built-in>: warning:   by ‘operator’ [-Woverloaded-virtual]
    /home/vlad/KDE/src/frameworks/kwayland/src/client/xdgshell_p.h:169:13: warning: ‘virtual KWayland::Client::XdgShellSurface::Private::operator zxdg_surface_v6*() const’ was hidden [-Woverloaded-virtual]
         virtual operator zxdg_surface_v6*() const {
                 ^~~~~~~~
    <built-in>: warning:   by ‘operator’ [-Woverloaded-virtual]
    /home/vlad/KDE/src/frameworks/kwayland/src/client/xdgshell_p.h:166:13: warning: ‘virtual KWayland::Client::XdgShellSurface::Private::operator zxdg_surface_v6*()’ was hidden [-Woverloaded-virtual]
         virtual operator zxdg_surface_v6*() {
                 ^~~~~~~~
    <built-in>: warning:   by ‘operator’ [-Woverloaded-virtual]
    /home/vlad/KDE/src/frameworks/kwayland/src/client/xdgshell_p.h:237:13: warning: ‘virtual KWayland::Client::XdgShellPopup::Private::operator zxdg_popup_v6*() const’ was hidden [-Woverloaded-virtual]
         virtual operator zxdg_popup_v6*() const {
                 ^~~~~~~~
    <built-in>: warning:   by ‘operator’ [-Woverloaded-virtual]
    /home/vlad/KDE/src/frameworks/kwayland/src/client/xdgshell_p.h:234:13: warning: ‘virtual KWayland::Client::XdgShellPopup::Private::operator zxdg_popup_v6*()’ was hidden [-Woverloaded-virtual]
         virtual operator zxdg_popup_v6*() {
                 ^~~~~~~~
    <built-in>: warning:   by ‘operator’ [-Woverloaded-virtual]
    /home/vlad/KDE/src/frameworks/kwayland/src/client/xdgshell_p.h:231:13: warning: ‘virtual KWayland::Client::XdgShellPopup::Private::operator zxdg_surface_v6*() const’ was hidden [-Woverloaded-virtual]
         virtual operator zxdg_surface_v6*() const {
                 ^~~~~~~~
    <built-in>: warning:   by ‘operator’ [-Woverloaded-virtual]
    /home/vlad/KDE/src/frameworks/kwayland/src/client/xdgshell_p.h:228:13: warning: ‘virtual KWayland::Client::XdgShellPopup::Private::operator zxdg_surface_v6*()’ was hidden [-Woverloaded-virtual]
         virtual operator zxdg_surface_v6*() {
                 ^~~~~~~~
    <built-in>: warning:   by ‘operator’ [-Woverloaded-virtual]

REPOSITORY
  R127 KWayland

REVISION DETAIL
  https://phabricator.kde.org/D13502

To: davidedmundson, #kwin
Cc: zzag, kde-frameworks-devel, michaelh, ngraham, bruns
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20180613/e71dc19e/attachment.html>