<table><tr><td style="">zzag added a comment.
</td><a style="text-decoration: none; padding: 4px 8px; margin: 0 8px 8px; float: right; color: #464C5C; font-weight: bold; border-radius: 3px; background-color: #F7F7F9; background-image: linear-gradient(to bottom,#fff,#f1f0f1); display: inline-block; border: 1px solid rgba(71,87,120,.2);" href="https://phabricator.kde.org/D13502">View Revision</a></tr></table><br /><div><div><blockquote style="border-left: 3px solid #a7b5bf; color: #464c5c; font-style: italic; margin: 4px 0 12px 0; padding: 4px 12px; background-color: #f8f9fc;"><p>Compiles with no warnings \o/</p></blockquote>

<p>Nope.</p>

<div class="remarkup-code-block" style="margin: 12px 0;" data-code-lang="text" data-sigil="remarkup-code-block"><pre class="remarkup-code" style="font: 11px/15px "Menlo", "Consolas", "Monaco", monospace; padding: 12px; margin: 0; background: rgba(71, 87, 120, 0.08);">In file included from /home/vlad/KDE/src/frameworks/kwayland/src/client/xdgshell_v6.cpp:20:
/home/vlad/KDE/src/frameworks/kwayland/src/client/xdgshell_p.h:49:13: warning: ‘virtual KWayland::Client::XdgShell::Private::operator xdg_shell*() const’ was hidden [-Woverloaded-virtual]
     virtual operator xdg_shell*() const {
             ^~~~~~~~
<built-in>: warning:   by ‘operator’ [-Woverloaded-virtual]
/home/vlad/KDE/src/frameworks/kwayland/src/client/xdgshell_p.h:46:13: warning: ‘virtual KWayland::Client::XdgShell::Private::operator xdg_shell*()’ was hidden [-Woverloaded-virtual]
     virtual operator xdg_shell*() {
             ^~~~~~~~
<built-in>: warning:   by ‘operator’ [-Woverloaded-virtual]
/home/vlad/KDE/src/frameworks/kwayland/src/client/xdgshell_p.h:60:28: warning: ‘virtual KWayland::Client::XdgShellPopup* KWayland::Client::XdgShell::Private::getXdgPopup(KWayland::Client::Surface*, KWayland::Client::Surface*, KWayland::Client::Seat*, quint32, const QPoint&, QObject*)’ was hidden [-Woverloaded-virtual]
     virtual XdgShellPopup *getXdgPopup(Surface *surface, Surface *parentSurface, Seat *seat, quint32 serial, const QPoint &parentPos, QObject *parent) {
                            ^~~~~~~~~~~
/home/vlad/KDE/src/frameworks/kwayland/src/client/xdgshell_v6.cpp:45:20: warning:   by ‘KWayland::Client::XdgShellUnstableV6::Private::getXdgPopup’ [-Woverloaded-virtual]
     XdgShellPopup *getXdgPopup(Surface *surface, XdgShellPopup *parentSurface, const XdgPositioner &positioner, QObject *parent) override;
                    ^~~~~~~~~~~
In file included from /home/vlad/KDE/src/frameworks/kwayland/src/client/xdgshell_v6.cpp:20:
/home/vlad/KDE/src/frameworks/kwayland/src/client/xdgshell_p.h:163:13: warning: ‘virtual KWayland::Client::XdgShellSurface::Private::operator xdg_surface*() const’ was hidden [-Woverloaded-virtual]
     virtual operator xdg_surface*() const {
             ^~~~~~~~
<built-in>: warning:   by ‘operator’ [-Woverloaded-virtual]
/home/vlad/KDE/src/frameworks/kwayland/src/client/xdgshell_p.h:160:13: warning: ‘virtual KWayland::Client::XdgShellSurface::Private::operator xdg_surface*()’ was hidden [-Woverloaded-virtual]
     virtual operator xdg_surface*() {
             ^~~~~~~~
<built-in>: warning:   by ‘operator’ [-Woverloaded-virtual]
/home/vlad/KDE/src/frameworks/kwayland/src/client/xdgshell_p.h:225:13: warning: ‘virtual KWayland::Client::XdgShellPopup::Private::operator xdg_popup*() const’ was hidden [-Woverloaded-virtual]
     virtual operator xdg_popup*() const {
             ^~~~~~~~
<built-in>: warning:   by ‘operator’ [-Woverloaded-virtual]
/home/vlad/KDE/src/frameworks/kwayland/src/client/xdgshell_p.h:222:13: warning: ‘virtual KWayland::Client::XdgShellPopup::Private::operator xdg_popup*()’ was hidden [-Woverloaded-virtual]
     virtual operator xdg_popup*() {
             ^~~~~~~~
<built-in>: warning:   by ‘operator’ [-Woverloaded-virtual]

In file included from /home/vlad/KDE/src/frameworks/kwayland/src/client/xdgshell_v5.cpp:20:
/home/vlad/KDE/src/frameworks/kwayland/src/client/xdgshell_p.h:55:13: warning: ‘virtual KWayland::Client::XdgShell::Private::operator zxdg_shell_v6*() const’ was hidden [-Woverloaded-virtual]
     virtual operator zxdg_shell_v6*() const {
             ^~~~~~~~
<built-in>: warning:   by ‘operator’ [-Woverloaded-virtual]
/home/vlad/KDE/src/frameworks/kwayland/src/client/xdgshell_p.h:52:13: warning: ‘virtual KWayland::Client::XdgShell::Private::operator zxdg_shell_v6*()’ was hidden [-Woverloaded-virtual]
     virtual operator zxdg_shell_v6*() {
             ^~~~~~~~
<built-in>: warning:   by ‘operator’ [-Woverloaded-virtual]
In file included from /home/vlad/KDE/src/frameworks/kwayland/src/client/xdgshell_v5.cpp:20:
/home/vlad/KDE/src/frameworks/kwayland/src/client/xdgshell_p.h:80:28: warning: ‘virtual KWayland::Client::XdgShellPopup* KWayland::Client::XdgShell::Private::getXdgPopup(KWayland::Client::Surface*, KWayland::Client::XdgShellPopup*, const KWayland::Client::XdgPositioner&, QObject*)’ was hidden [-Woverloaded-virtual]
     virtual XdgShellPopup *getXdgPopup(Surface *surface, XdgShellPopup *parentSurface, const XdgPositioner &positioner, QObject *parent) {
                            ^~~~~~~~~~~
/home/vlad/KDE/src/frameworks/kwayland/src/client/xdgshell_v5.cpp:41:20: warning:   by ‘virtual KWayland::Client::XdgShellPopup* KWayland::Client::XdgShellUnstableV5::Private::getXdgPopup(KWayland::Client::Surface*, KWayland::Client::Surface*, KWayland::Client::Seat*, quint32, const QPoint&, QObject*)’ [-Woverloaded-virtual]
     XdgShellPopup *getXdgPopup(Surface *surface, Surface *parentSurface, Seat *seat, quint32 serial, const QPoint &parentPos, QObject *parent) override;
                    ^~~~~~~~~~~
In file included from /home/vlad/KDE/src/frameworks/kwayland/src/client/xdgshell_v5.cpp:20:
/home/vlad/KDE/src/frameworks/kwayland/src/client/xdgshell_p.h:71:28: warning: ‘virtual KWayland::Client::XdgShellPopup* KWayland::Client::XdgShell::Private::getXdgPopup(KWayland::Client::Surface*, KWayland::Client::XdgShellSurface*, const KWayland::Client::XdgPositioner&, QObject*)’ was hidden [-Woverloaded-virtual]
     virtual XdgShellPopup *getXdgPopup(Surface *surface, XdgShellSurface *parentSurface, const XdgPositioner &positioner, QObject *parent) {
                            ^~~~~~~~~~~
/home/vlad/KDE/src/frameworks/kwayland/src/client/xdgshell_v5.cpp:41:20: warning:   by ‘virtual KWayland::Client::XdgShellPopup* KWayland::Client::XdgShellUnstableV5::Private::getXdgPopup(KWayland::Client::Surface*, KWayland::Client::Surface*, KWayland::Client::Seat*, quint32, const QPoint&, QObject*)’ [-Woverloaded-virtual]
     XdgShellPopup *getXdgPopup(Surface *surface, Surface *parentSurface, Seat *seat, quint32 serial, const QPoint &parentPos, QObject *parent) override;
                    ^~~~~~~~~~~
In file included from /home/vlad/KDE/src/frameworks/kwayland/src/client/xdgshell_v5.cpp:20:
/home/vlad/KDE/src/frameworks/kwayland/src/client/xdgshell_p.h:175:13: warning: ‘virtual KWayland::Client::XdgShellSurface::Private::operator zxdg_toplevel_v6*() const’ was hidden [-Woverloaded-virtual]
     virtual operator zxdg_toplevel_v6*() const {
             ^~~~~~~~
<built-in>: warning:   by ‘operator’ [-Woverloaded-virtual]
/home/vlad/KDE/src/frameworks/kwayland/src/client/xdgshell_p.h:172:13: warning: ‘virtual KWayland::Client::XdgShellSurface::Private::operator zxdg_toplevel_v6*()’ was hidden [-Woverloaded-virtual]
     virtual operator zxdg_toplevel_v6*() {
             ^~~~~~~~
<built-in>: warning:   by ‘operator’ [-Woverloaded-virtual]
/home/vlad/KDE/src/frameworks/kwayland/src/client/xdgshell_p.h:169:13: warning: ‘virtual KWayland::Client::XdgShellSurface::Private::operator zxdg_surface_v6*() const’ was hidden [-Woverloaded-virtual]
     virtual operator zxdg_surface_v6*() const {
             ^~~~~~~~
<built-in>: warning:   by ‘operator’ [-Woverloaded-virtual]
/home/vlad/KDE/src/frameworks/kwayland/src/client/xdgshell_p.h:166:13: warning: ‘virtual KWayland::Client::XdgShellSurface::Private::operator zxdg_surface_v6*()’ was hidden [-Woverloaded-virtual]
     virtual operator zxdg_surface_v6*() {
             ^~~~~~~~
<built-in>: warning:   by ‘operator’ [-Woverloaded-virtual]
/home/vlad/KDE/src/frameworks/kwayland/src/client/xdgshell_p.h:237:13: warning: ‘virtual KWayland::Client::XdgShellPopup::Private::operator zxdg_popup_v6*() const’ was hidden [-Woverloaded-virtual]
     virtual operator zxdg_popup_v6*() const {
             ^~~~~~~~
<built-in>: warning:   by ‘operator’ [-Woverloaded-virtual]
/home/vlad/KDE/src/frameworks/kwayland/src/client/xdgshell_p.h:234:13: warning: ‘virtual KWayland::Client::XdgShellPopup::Private::operator zxdg_popup_v6*()’ was hidden [-Woverloaded-virtual]
     virtual operator zxdg_popup_v6*() {
             ^~~~~~~~
<built-in>: warning:   by ‘operator’ [-Woverloaded-virtual]
/home/vlad/KDE/src/frameworks/kwayland/src/client/xdgshell_p.h:231:13: warning: ‘virtual KWayland::Client::XdgShellPopup::Private::operator zxdg_surface_v6*() const’ was hidden [-Woverloaded-virtual]
     virtual operator zxdg_surface_v6*() const {
             ^~~~~~~~
<built-in>: warning:   by ‘operator’ [-Woverloaded-virtual]
/home/vlad/KDE/src/frameworks/kwayland/src/client/xdgshell_p.h:228:13: warning: ‘virtual KWayland::Client::XdgShellPopup::Private::operator zxdg_surface_v6*()’ was hidden [-Woverloaded-virtual]
     virtual operator zxdg_surface_v6*() {
             ^~~~~~~~
<built-in>: warning:   by ‘operator’ [-Woverloaded-virtual]</pre></div></div></div><br /><div><strong>REPOSITORY</strong><div><div>R127 KWayland</div></div></div><br /><div><strong>REVISION DETAIL</strong><div><a href="https://phabricator.kde.org/D13502">https://phabricator.kde.org/D13502</a></div></div><br /><div><strong>To: </strong>davidedmundson, KWin<br /><strong>Cc: </strong>zzag, kde-frameworks-devel, michaelh, ngraham, bruns<br /></div>