D13216: Overhaul the file index scheduler.

James Smith noreply at phabricator.kde.org
Thu Jun 7 20:02:40 UTC 2018


smithjd added a comment.


  In D13216#275538 <https://phabricator.kde.org/D13216#275538>, @bruns wrote:
  
  > @smithjd You have probaly become another victim of phabricator/arc.  Your commits have been squashed by arc ...
  >  If you wan't your commits to stay separated, you have to do a `git checkout` of the first commit, do a `arc diff HEAD^1`, checkout the next commit, `arc diff HEAD^1`, and so on.
  
  
  Commits are squashed on arc land anyway, but the branch can be manually pushed keeping the separate patches. If you mean separated into different reviews, I don't think it's unclear why there are small changes to code related to the scheduler, or why it might be advantageous to separate these into different reviews.
  
  Is there any practical reason why a simple arc land wouldn't suffice here?

REPOSITORY
  R293 Baloo

REVISION DETAIL
  https://phabricator.kde.org/D13216

To: smithjd, bruns, mgallien
Cc: kde-frameworks-devel, #baloo, ashaposhnikov, michaelh, astippich, spoorun, ngraham, bruns
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20180607/68dea06d/attachment.html>


More information about the Kde-frameworks-devel mailing list