D12696: Use the new uds implementation

[Martin Kostolný]

martinkostolny added a comment.


  Hi! Probably after this commit sftp slave crashes when showing a directory with links. Please see my code comment. Can you also reproduce or is it on my side only?
  
  Here is a crash log:
  
    log_kio_sftp: readdir:  "/mnt/ext/files" , details:  "2"
    ASSERT: "std::find_if(storage.cbegin(), storage.cend(), [udsField](const Field &entry) {return entry.m_index == udsField;}) == storage.cend()" in file /home/kotelnik/kde/src/frameworks/kio/src/core/udsentry.cpp, line 107
    kioslave: ####### CRASH ###### protocol = kio_sftp pid = 20126 signal = 6
    /home/kotelnik/kde/usr/lib64/libKF5KIOCore.so.5(+0x9d42d)[0x7fa660a1042d]
    /usr/lib/libc.so.6(+0x368f0)[0x7fa6689888f0]
    /usr/lib/libc.so.6(gsignal+0x10b)[0x7fa66898886b]
    /usr/lib/libc.so.6(abort+0x129)[0x7fa66897340e]
    /usr/lib/libQt5Core.so.5(+0x8033c)[0x7fa6696c433c]
    /usr/lib/libQt5Core.so.5(_Z11qt_assert_xPKcS0_S0_i+0x0)[0x7fa6696c3768]
    /home/kotelnik/kde/usr/lib64/libKF5KIOCore.so.5(+0x1033bb)[0x7fa660a763bb]
    /home/kotelnik/kde/usr/lib64/libKF5KIOCore.so.5(_ZN3KIO8UDSEntry6insertEjx+0x33)[0x7fa660a78403]
    /home/kotelnik/kde/usr/lib64/plugins/kf5/kio/sftp.so(+0x12371)[0x7fa657ee4371]
    /home/kotelnik/kde/usr/lib64/libKF5KIOCore.so.5(_ZN3KIO9SlaveBase8dispatchEiRK10QByteArray+0x86f)[0x7fa660a12961]
    /home/kotelnik/kde/usr/lib64/libKF5KIOCore.so.5(_ZN3KIO9SlaveBase12dispatchLoopEv+0x2a0)[0x7fa660a0e2aa]
    /home/kotelnik/kde/usr/lib64/plugins/kf5/kio/sftp.so(kdemain+0x264)[0x7fa657ed88ca]

INLINE COMMENTS

> udsentry.cpp:106
> +    Q_ASSERT(udsField & KIO::UDSEntry::UDS_NUMBER);
> +    Q_ASSERT(std::find_if(storage.cbegin(), storage.cend(),
> +                                [udsField](const Field &entry) {return entry.m_index == udsField;}) == storage.cend());

sftp slave crashes here when entering directory with links

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D12696

To: jtamate, dfaure, #frameworks
Cc: martinkostolny, kde-frameworks-devel, bruns, michaelh, ngraham
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20180607/5e181693/attachment-0001.html>