D13302: check for needed version of libavcode, libavformat and libavutil
Roman Gilg
noreply at phabricator.kde.org
Sun Jun 3 14:29:05 UTC 2018
romangg added a comment.
I tried this patch on Neon with FFmpeg 2.8.14.
KFileMetaData builds now because it detects that the FFmpeg module version numbers are too low.
CMake log: P230 <https://phabricator.kde.org/P230>
Few remarks:
- In the log it says 3 times `Could NOT find FFmpeg (missing: HAVE_AVSTREAM_CODECPAR) (Required is at least version "<version number>")` with `<version number>` being different values.
- In the log it shows now nowhere 2.8.14 for FFmpeg anymore. In the end it falsely says: `FFmpeg (required version >= 55.27)`
- Instead of building on Neon without FFmpeg support KFileMetaData should just fall back to using the deprecated function name `AVCodecContext` or better we should revert 037208a787e0 <https://phabricator.kde.org/R286:037208a787e0c2412ab616ff1573c323a2346d2d> and 3415015e3d45 <https://phabricator.kde.org/R286:3415015e3d45ce485c5cdb1bc47698729deb8d98> as long as Neon is not with FFmpeg >= 3.1 (but improving the FFmpeg version detection as tried with this patch here would still be good of course).
REPOSITORY
R286 KFileMetaData
REVISION DETAIL
https://phabricator.kde.org/D13302
To: mgallien, romangg, adridg
Cc: kde-frameworks-devel, #baloo, ashaposhnikov, michaelh, astippich, spoorun, ngraham, bruns
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20180603/d58f7484/attachment.html>
More information about the Kde-frameworks-devel
mailing list