Pre-review CI

[Bhushan Shah]

On Sun, Jul 29, 2018 at 05:00:19PM +0200, Friedrich W. H. Kossebau wrote:
> 1 job means one huge build log to look at, or? In that case I would prefer 
> separate jobs. Given review requests are prone to fail.

Thing is, you don't care about the pre-review CI jobs as long as they
are passing, but in case of fail, yes you might have to look at long
log depending on where failure was, in first platform or last one.

> compare to non-review build jobs, I would assume. And having jobs separate 
> also means one gets results for any platforms, does not stop on the first 
> failing?

Yes, but it also means that if there is obvious mistake in review, all
will fail, insteaad of bailing out earlier.

> All that said though without having seen how a one-job-to-rule-them-all would 
> look like, and how the others. Any chance for some samples, please?

We haven't enabled multi-platform jobs currently but it would be
basically for each platform (linux, windows, FreeBSD, Android). It will
execute them in order, and if one fails, it will just bail out.

> > - Should we send out comment for failure and success? Or is it easier to
> >   figure out the console log link without the comment? See linked review
> >   for example [1].
> 
> [1] -> [2] here.
> 
> What do you mean exactly by "send out comment for failure and success"? More 
> emails? (Please not). That example works fine with me, but not sure what the 
> alternative is?

The alternative being, instead of jenkins-ci comemnting with link, you
find it manually in Diff detail section, see screenshot

https://screenshots.firefox.com/1GG7B0bPLod3QMFg/phabricator.kde.org

Here, the "Jenkins" after the "Build 1313: Frameworks Pre-Review CI" is
link to jenkins build. But the test was if you were able to spot it in
first glance, and it failed. :P so yeah we will keep comments enabled
even if it means extra emails.

> Cheers and Thanks again for improving the review system
> Friedrich

Thanks

-- 
Bhushan Shah
http://blog.bshah.in
IRC Nick : bshah on Freenode
GPG key fingerprint : 0AAC 775B B643 7A8D 9AF7 A3AC FE07 8411 7FBC E11D
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 488 bytes
Desc: not available
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20180730/eac913ed/attachment-0001.sig>