D14308: [Exe Thumbnailer] Improve icon selection algorithm

[Nathaniel Graham]

ngraham added a comment.


  What a dramatic set of before-and-after images! It's like we jumped from 1991 to 2018.
  
  > Algo is basically copied from Plasma's wallpaper selection
  
  Sounds like we should put this in a Framework and re-use it instead of copy-pasting it here.

INLINE COMMENTS

> icoutils_common.cpp:33
> +
> +    return qAbs(candidateAspectRatio - desiredAspectRatio) * 25000 + delta;
> +}

Where does this magic number come from?

REPOSITORY
  R320 KIO Extras

REVISION DETAIL
  https://phabricator.kde.org/D14308

To: broulik, #frameworks, dfaure, ngraham, pali, vonreth, antlarr
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20180723/ec5a0c7b/attachment.html>