D14308: [Exe Thumbnailer] Improve icon selection algorithm

Kai Uwe Broulik noreply at phabricator.kde.org
Mon Jul 23 19:58:11 BST 2018


broulik created this revision.
broulik added reviewers: Frameworks, dfaure, ngraham, pali, vonreth, antlarr.
broulik requested review of this revision.

REVISION SUMMARY
  Prefer downsampling over upscaling

TEST PLAN
  Dolphin requested 128px thumbnail here. Wine executables have 32, 48, and 256 icons. It would pick the 48 one:
  F6132594: Screenshot_20180723_204523.png <https://phabricator.kde.org/F6132594>
  Afterwards it would use the 256 ones
  F6132596: Screenshot_20180723_204442.png <https://phabricator.kde.org/F6132596>
  The effect isn't neccessarily as noticeable with every icon and I hardly have any "real" windows EXE files around to test :)
  Algo is basically copied from Plasma's wallpaper selection

REPOSITORY
  R320 KIO Extras

REVISION DETAIL
  https://phabricator.kde.org/D14308

AFFECTED FILES
  thumbnail/icoutils_common.cpp

To: broulik, #frameworks, dfaure, ngraham, pali, vonreth, antlarr
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20180723/bd911513/attachment.html>


More information about the Kde-frameworks-devel mailing list