D14175: Support cursor hints on locked pointer

[David Edmundson]

davidedmundson requested changes to this revision.
davidedmundson added inline comments.
This revision now requires changes to proceed.

INLINE COMMENTS

> test_pointer_constraints.cpp:258
> +    QVERIFY(hintChangedSpy.wait());
> +
>      // and unlock again

We should check the value of hintChangedSpy.first() to properly test it.

Also, use something better than 1,0 to check y is set correctly

> pointerconstraints_interface.h:126
>      QRegion region() const;
>  
>      /**

do we not want a getter method?

One of kwayland's main roles is to be a property cache

> pointerconstraints_interface.h:165
> +     * should be ignored by the compositor.
> +     *
> +     **/

@since

> pointerconstraints_interface_v1.cpp:175
> +    auto p = cast<Private>(resource);
> +    p->pendingHint = QPointF(wl_fixed_to_double(surface_x), wl_fixed_to_double(surface_y));
> +    p->hintIsSet = true;

Only non-negative x and y values are allowed

is it worth enforcing that with a check here?

REPOSITORY
  R127 KWayland

REVISION DETAIL
  https://phabricator.kde.org/D14175

To: romangg, #plasma, davidedmundson
Cc: davidedmundson, kde-frameworks-devel, michaelh, ngraham, bruns
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20180717/85007437/attachment-0001.html>