D13933: [Purpose]: use Arc's status colours for the Phab plugin drop-down list (WIP)

Aleix Pol Gonzalez noreply at phabricator.kde.org
Tue Jul 10 16:39:26 BST 2018


apol accepted this revision.
apol added a comment.
This revision is now accepted and ready to land.


  LGTM overall.

INLINE COMMENTS

> difflistmodel.cpp:87
>      if (job->error() != 0) {
> -        qWarning() << "error getting differential revision list" << job->errorString();
> +        qDebug() << "error getting differential revision list" << job->errorString();
>          beginResetModel();

Why that change?

REPOSITORY
  R495 Purpose Library

REVISION DETAIL
  https://phabricator.kde.org/D13933

To: rjvbb, apol
Cc: kde-frameworks-devel, michaelh, ngraham, bruns
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20180710/497e2e4e/attachment.html>


More information about the Kde-frameworks-devel mailing list