D13814: Speedup sort

[Mark Gaiser]

markg added a comment.


  In D13814#287959 <https://phabricator.kde.org/D13814#287959>, @jtamate wrote:
  
  > I really, really hate these things. 
  >  I've been testing this patch more than one month without any problem.
  >  And now, after pushing it, I got crashes everytime I start dolphin without parameters (user home).
  >  But not if I start it in / and keep changing directories, including user home.
  >
  > Please, test dolphin with latest sources.
  >
  > #6  0x00007fc0ba4e5904 in icu_61_1::RuleBasedCollator::getAttribute(UColAttribute, UErrorCode&) const () from /usr/lib64/libicui18n.so.61.1
  >  #7  0x00007fc0ba4e6dc6 in icu_61_1::RuleBasedCollator::setAttribute(UColAttribute, UColAttributeValue, UErrorCode&) () from /usr/lib64/libicui18n.so.61.1
  >  #8  0x00007fc0c0dfec25 in QCollatorPrivate::init() () at tools/qcollator_icu.cpp:82
  >  #9  0x00007fc0c0dfedab in QCollator::compare (this=0x1928070, s1=0x1bd6b98, len1=19, s2=0x1d70af8, len2=17) at tools/qcollator_icu.cpp:109
  >  #10 0x00007fc0c880ac30 in KFileItemModel::sortRoleCompare (this=this at entry=0x1928040, a=a at entry=0x1c0e1f0, b=b at entry=0x1cfbdf0, collator=...) at /g/5kde/kde/applications/dolphin/src/kitemviews/kfileitemmodel.cpp:1836
  >  #11 0x00007fc0c880b2a2 in KFileItemModel::lessThan (this=this at entry=0x1928040, a=0x1c0e1f0, b=0x1cfbdf0, collator=...) at /g/5kde/kde/applications/dolphin/src/kitemviews/kfileitemmodel.cpp:1707
  >  #12 0x00007fc0c8811715 in KFileItemModel::<lambda(const KFileItemModel::ItemData*, const KFileItemModel::ItemData*)>::operator() (__closure=0x7ffe8d4307a8, b=<optimized out>, a=<optimized out>) at /g/5kde/kde/applications/dolphin/src/kitemviews/kfileitemmodel.cpp:1717
  
  
  I just cloned dolphin with your changes.
  It compiled just fine.
  Starting it with and without arguments also worked just fine.
  
  Perhaps it's a local issue on your side? Have you tried cleaning your dolphin build (and perhaps KIO as well) and re-run it to see if it still happens?

REPOSITORY
  R318 Dolphin

REVISION DETAIL
  https://phabricator.kde.org/D13814

To: jtamate, #dolphin, #frameworks, markg, elvisangelaccio
Cc: elvisangelaccio, apol, bruns, markg, kfm-devel, spoorun, navarromorales, firef, andrebarros, emmanuelp
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20180707/daaacadb/attachment.html>