D13813: Make this test work again with new uds implementation

David Faure noreply at phabricator.kde.org
Wed Jul 4 21:35:17 BST 2018


dfaure added a comment.


  In D13813#287032 <https://phabricator.kde.org/D13813#287032>, @jtamate wrote:
  
  > > But ForwardingSlaveBase::prepareUDSEntry in KIO itself, uses insert() to replace UDS_URL, and in fact all of ForwardingSlaveBase should use replace(), as well as users of ForwardingSlaveBase like kio_desktop.
  >
  > In ForwardingSlaveBase::prepareUDSEntry, it uses insert() only to insert an UDS URL, because it is done only if the UDS URL is empty, isn't it?
  >  But for UDS_LOCAL_PATH, I guess you're right, it should use replace().
  
  
  No, it replaces the URL if it was found, i.e. not empty.
  
  In any case, can you first restore compat?

REPOSITORY
  R318 Dolphin

REVISION DETAIL
  https://phabricator.kde.org/D13813

To: jtamate, #dolphin, #frameworks, elvisangelaccio
Cc: dfaure, aacid, ngraham, bruns, elvisangelaccio, kfm-devel, spoorun, navarromorales, firef, andrebarros, emmanuelp
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20180704/2476d68d/attachment-0001.html>


More information about the Kde-frameworks-devel mailing list