D13813: Make this test work again with new uds implementation

Jaime Torres Amate noreply at phabricator.kde.org
Wed Jul 4 21:16:48 BST 2018


jtamate added a comment.


  > But ForwardingSlaveBase::prepareUDSEntry in KIO itself, uses insert() to replace UDS_URL, and in fact all of ForwardingSlaveBase should use replace(), as well as users of ForwardingSlaveBase like kio_desktop.
  
  In ForwardingSlaveBase::prepareUDSEntry, it uses insert() only to insert an UDS URL, because it is done only if the UDS URL is empty, isn't it?
  But for UDS_LOCAL_PATH, I guess you're right, it should use replace().

REPOSITORY
  R318 Dolphin

REVISION DETAIL
  https://phabricator.kde.org/D13813

To: jtamate, #dolphin, #frameworks, elvisangelaccio
Cc: dfaure, aacid, ngraham, bruns, elvisangelaccio, kfm-devel, spoorun, navarromorales, firef, andrebarros, emmanuelp
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20180704/ab908aa7/attachment.html>


More information about the Kde-frameworks-devel mailing list