D10045: Don't assert on empty names

[David Faure]

dfaure added a comment.


  See https://phabricator.kde.org/D10172 for the fix for the first usability issue.
  
  However I can't reproduce the assert...
  Can you add this to your kio_remote to find out more?
  There must be one strange .desktop file around somewhere.
  
    diff --git a/src/ioslaves/remote/remoteimpl.cpp b/src/ioslaves/remote/remoteimpl.cpp
    index 6d01cc8cf7..3376d619b9 100644
    --- a/src/ioslaves/remote/remoteimpl.cpp
    +++ b/src/ioslaves/remote/remoteimpl.cpp
    @@ -184,6 +184,8 @@ void RemoteImpl::createEntry(KIO::UDSEntry &entry, const QString &directory,
         QString new_filename = file;
         new_filename.truncate(file.length()-8);
     
    +    qDebug() << "UDS_NAME" << desktop.readName() << "from" << (dir+file);
    +    Q_ASSERT(!desktop.readName().isEmpty());
         entry.insert(KIO::UDSEntry::UDS_NAME, desktop.readName());
         entry.insert(KIO::UDSEntry::UDS_URL, "remote:/"+new_filename);

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D10045

To: mwolff, dfaure
Cc: dhaumann, #frameworks, michaelh
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20180129/4cf19a54/attachment.html>