D10040: Add serial number and EISA ID to OutputDevice interface

[David Edmundson]

davidedmundson added inline comments.

INLINE COMMENTS

> outputdevice.xml:32
>  
>  <interface name="org_kde_kwin_outputdevice" version="1">
>      <description summary="compositor output region">

you need to bump this

> outputdevice_interface.cpp:450
>  SETTER(setModel, const QString&, model)
> +SETTER(setSerialNumber, const QString&, serialNumber)
> +SETTER(setEisaId, const QString&, eisaId)

You're not actually sending the serial number or eisa anywhere..

The others do it in sendGeometry (including the manufacturer)

When you do add it, you need to check the client is bound with version 2, otherwise you'll crash the client.

Something like
 if(wl_proxy_get_version(resourceOfBoundClient) >= ORG_KDE_KWIN_SETSERIAL_SINCE_VERSION) {

  org_kde_output_...

REPOSITORY
  R127 KWayland

REVISION DETAIL
  https://phabricator.kde.org/D10040

To: dvratil, graesslin, sebas
Cc: davidedmundson, plasma-devel, #frameworks, schernikov, ZrenBot, ngraham, alexeymin, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, eliasp, sebas, apol, mart, hein
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20180123/377099fc/attachment.html>