<table><tr><td style="">davidedmundson added inline comments.
</td><a style="text-decoration: none; padding: 4px 8px; margin: 0 8px 8px; float: right; color: #464C5C; font-weight: bold; border-radius: 3px; background-color: #F7F7F9; background-image: linear-gradient(to bottom,#fff,#f1f0f1); display: inline-block; border: 1px solid rgba(71,87,120,.2);" href="https://phabricator.kde.org/D10040" rel="noreferrer">View Revision</a></tr></table><br /><div><strong>INLINE COMMENTS</strong><div><div style="margin: 6px 0 12px 0;"><div style="border: 1px solid #C7CCD9; border-radius: 3px;"><div style="padding: 0; background: #F7F7F7; border-color: #e3e4e8; border-style: solid; border-width: 0 0 1px 0; margin: 0;"><div style="color: #74777d; background: #eff2f4; padding: 6px 8px; overflow: hidden;"><a style="float: right; text-decoration: none;" href="https://phabricator.kde.org/D10040#inline-46097" rel="noreferrer">View Inline</a><span style="color: #4b4d51; font-weight: bold;">outputdevice.xml:32</span></div>
<div style="font: 11px/15px "Menlo", "Consolas", "Monaco", monospace; white-space: pre-wrap; clear: both; padding: 4px 0; margin: 0;"><div style="padding: 0 8px; margin: 0 4px; "><span style="color: #00702a"><interface</span> <span style="color: #354bb3">name=</span><span style="color: #766510">"org_kde_kwin_outputdevice"</span> <span style="color: #354bb3">version=</span><span style="color: #766510">"1"</span><span style="color: #00702a">></span>
</div><div style="padding: 0 8px; margin: 0 4px; ">    <span style="color: #00702a"><description</span> <span style="color: #354bb3">summary=</span><span style="color: #766510">"compositor output region"</span><span style="color: #00702a">></span>
</div></div></div>
<div style="margin: 8px 0; padding: 0 12px;"><p style="padding: 0; margin: 8px;">you need to bump this</p></div></div><br /><div style="border: 1px solid #C7CCD9; border-radius: 3px;"><div style="padding: 0; background: #F7F7F7; border-color: #e3e4e8; border-style: solid; border-width: 0 0 1px 0; margin: 0;"><div style="color: #74777d; background: #eff2f4; padding: 6px 8px; overflow: hidden;"><a style="float: right; text-decoration: none;" href="https://phabricator.kde.org/D10040#inline-46099" rel="noreferrer">View Inline</a><span style="color: #4b4d51; font-weight: bold;">outputdevice_interface.cpp:450</span></div>
<div style="font: 11px/15px "Menlo", "Consolas", "Monaco", monospace; white-space: pre-wrap; clear: both; padding: 4px 0; margin: 0;"><div style="padding: 0 8px; margin: 0 4px; "><span class="n">SETTER</span><span class="p">(</span><span class="n">setModel</span><span class="p">,</span> <span style="color: #aa4000">const</span> <span class="n">QString</span><span style="color: #aa2211">&</span><span class="p">,</span> <span class="n">model</span><span class="p">)</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);"><span class="n">SETTER</span><span class="p">(</span><span class="n">setSerialNumber</span><span class="p">,</span> <span style="color: #aa4000">const</span> <span class="n">QString</span><span style="color: #aa2211">&</span><span class="p">,</span> <span class="n">serialNumber</span><span class="p">)</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);"><span class="n">SETTER</span><span class="p">(</span><span class="n">setEisaId</span><span class="p">,</span> <span style="color: #aa4000">const</span> <span class="n">QString</span><span style="color: #aa2211">&</span><span class="p">,</span> <span class="n">eisaId</span><span class="p">)</span>
</div></div></div>
<div style="margin: 8px 0; padding: 0 12px;"><p style="padding: 0; margin: 8px;">You're not actually sending the serial number or eisa anywhere..</p>

<p style="padding: 0; margin: 8px;">The others do it in sendGeometry (including the manufacturer)</p>

<p style="padding: 0; margin: 8px;">When you do add it, you need to check the client is bound with version 2, otherwise you'll crash the client.</p>

<p style="padding: 0; margin: 8px;">Something like<br />
 if(wl_proxy_get_version(resourceOfBoundClient) >= ORG_KDE_KWIN_SETSERIAL_SINCE_VERSION) {</p>

<div class="remarkup-code-block" style="margin: 12px 0;" data-code-lang="text" data-sigil="remarkup-code-block"><pre class="remarkup-code" style="font: 11px/15px "Menlo", "Consolas", "Monaco", monospace; padding: 12px; margin: 0; background: rgba(71, 87, 120, 0.08);">org_kde_output_...</pre></div></div></div></div></div></div><br /><div><strong>REPOSITORY</strong><div><div>R127 KWayland</div></div></div><br /><div><strong>REVISION DETAIL</strong><div><a href="https://phabricator.kde.org/D10040" rel="noreferrer">https://phabricator.kde.org/D10040</a></div></div><br /><div><strong>To: </strong>dvratil, graesslin, sebas<br /><strong>Cc: </strong>davidedmundson, plasma-devel, Frameworks, schernikov, ZrenBot, ngraham, alexeymin, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, eliasp, sebas, apol, mart, hein<br /></div>