D9840: Tentative patch to reduce I/O overhead of plasmashell when copying files

[Jaime Torres Amate]

jtamate added a comment.


  Yes, you are right, it doesn't pass the unittests with this tentative patch.
  
  Some local changes should have triggered the heavy load, because now I'm not able to reproduce them.
  
  But there is a problem somewhere (I'll investigate further) because today, everytime I change directory in dolphin (even in /d/....), or change tabs in konsole, or change file to edit in kate or save a file in kate, a messagebox is shown or a notification is shown, there is a check for the timestamps, and this check has to check all the directories in the QMap:
  
  checking file timestamps for  QMap(("/etc/xdg/menus", 1515667084956)("/home/jtorres/.config/menus", 1515507849227)("/home/jtorres/.local/share/applications", 1515507849219)("/home/jtorres/.local/share/kservices5", 0)("/home/jtorres/.local/share/kservicetypes5", 0)("/home/jtorres/.local/share/mime", 1512993366020)("/usr/local/share/applications", 1515667254872)("/usr/local/share/kservices5", 0)("/usr/local/share/kservicetypes5", 0)("/usr/local/share/mime", 0)("/usr/share/applications", 1515667274588)("/usr/share/kservices5", 1515667109372)("/usr/share/kservicetypes5", 1515667086640)("/usr/share/mime", 1515667195828))
  
  And the directories watched by KDirWatch m_fileWatcher are:
  kf5.kcoreaddons.kdirwatch: Entries watched:
  kf5.kcoreaddons.kdirwatch:    [ Entry for "/", dir, using INotify inotify_wd=6, has 0 clients , nonexistent subentries: 0x20e45f0 "/.directory" ]
  kf5.kcoreaddons.kdirwatch:     dependent entries:
  kf5.kcoreaddons.kdirwatch:        0x20e45f0 "/.directory" NonExistent
  kf5.kcoreaddons.kdirwatch:    [ Entry for "/.directory", file, non-existent, using INotify inotify_wd=-1, has 2 clients ]
  kf5.kcoreaddons.kdirwatch:     by  "KDirWatch-3"  ( 1  times) ""
  kf5.kcoreaddons.kdirwatch:     by  "KDirWatch-5"  ( 1  times) ""
  kf5.kcoreaddons.kdirwatch:    [ Entry for "/etc/xdg/taskmanagerrulesrc", file, using INotify inotify_wd=9, has 1 clients ]
  kf5.kcoreaddons.kdirwatch:     by  "KDirWatch-8"  ( 1  times) ""
  kf5.kcoreaddons.kdirwatch:    [ Entry for "/home/jtorres/.cache/ksycoca5_es_EE55KafscqW408BVSKZuHAbUvuI=", file, using INotify inotify_wd=1, has 1 clients ]
  kf5.kcoreaddons.kdirwatch:     by  "KDirWatch-1"  ( 2  times) ""
  kf5.kcoreaddons.kdirwatch:    [ Entry for "/home/jtorres/.config", dir, using INotify inotify_wd=8, has 0 clients , nonexistent subentries: 0x43c53f0 "/home/jtorres/.config/taskmanagerrulesrc" 0x446ba20 "/home/jtorres/.config/klaunchrc" ]
  kf5.kcoreaddons.kdirwatch:     dependent entries:
  kf5.kcoreaddons.kdirwatch:        0x43c53f0 "/home/jtorres/.config/taskmanagerrulesrc" NonExistent
  kf5.kcoreaddons.kdirwatch:        0x446ba20 "/home/jtorres/.config/klaunchrc" NonExistent
  kf5.kcoreaddons.kdirwatch:    [ Entry for "/home/jtorres/.config/klaunchrc", file, non-existent, using INotify inotify_wd=-1, has 1 clients ]
  kf5.kcoreaddons.kdirwatch:     by  "KDirWatch-9"  ( 1  times) ""
  kf5.kcoreaddons.kdirwatch:    [ Entry for "/home/jtorres/.config/ksmserverrc", file, using INotify inotify_wd=7, has 1 clients ]
  kf5.kcoreaddons.kdirwatch:     by  "KDirWatch-7"  ( 1  times) ""
  kf5.kcoreaddons.kdirwatch:    [ Entry for "/home/jtorres/.config/plasma-org.kde.plasma.desktop-appletsrc", file, using INotify inotify_wd=5, has 1 clients ]
  kf5.kcoreaddons.kdirwatch:     by  "KDirWatch-2"  ( 1  times) ""
  kf5.kcoreaddons.kdirwatch:    [ Entry for "/home/jtorres/.config/plasmarc", file, using INotify inotify_wd=2, has 1 clients ]
  kf5.kcoreaddons.kdirwatch:     by  "KDirWatch-2"  ( 60  times) ""
  kf5.kcoreaddons.kdirwatch:    [ Entry for "/home/jtorres/.config/taskmanagerrulesrc", file, non-existent, using INotify inotify_wd=-1, has 1 clients ]
  kf5.kcoreaddons.kdirwatch:     by  "KDirWatch-8"  ( 1  times) ""
  kf5.kcoreaddons.kdirwatch:    [ Entry for "/usr/share/icons/breeze/index.theme", file, using INotify inotify_wd=4, has 1 clients ]
  kf5.kcoreaddons.kdirwatch:     by  "KDirWatch-2"  ( 1  times) ""
  kf5.kcoreaddons.kdirwatch:    [ Entry for "/usr/share/plasma/desktoptheme/default/metadata.desktop", file, using INotify inotify_wd=3, has 1 clients ]
  kf5.kcoreaddons.kdirwatch:     by  "KDirWatch-2"  ( 1  times) ""
  kf5.kcoreaddons.kdirwatch:    [ Entry for "/usr/share/solid/actions", dir, using INotify inotify_wd=10, has 1 clients ]
  kf5.kcoreaddons.kdirwatch:     by  "KDirWatch-10"  ( 1  times) ""

REPOSITORY
  R309 KService

REVISION DETAIL
  https://phabricator.kde.org/D9840

To: jtamate, #frameworks, dfaure
Cc: ngraham, mmustac
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20180115/c5323327/attachment-0001.html>