D9824: Optimize inotify KDirWatch backend: map inotify wd to Entry

[René J.V. Bertin]

rjvbb added a comment.


  Please test this for the QFSW backend too and post a benchmark result comparison (and include the change if beneficial).
  
  The QFSW backend is used on other Unices, Mac and on Linux when the inotify backend cannot be used (NFS, for instance).

INLINE COMMENTS

> kdirwatch_p.h:224
>      int m_inotify_fd;
> +    QHash<int, Entry *> m_inotify_wd_to_entry;
>  

How much overhead does this give per watched item?

I mean in bytes but I'm guessing there might be a break-even point, a number of entries under which the look-up in the map is more expensive than the current implementation. That could affect applications using KDW to monitor a tiny number of files. If correct, what kind of overhead are we talking about?

REPOSITORY
  R244 KCoreAddons

REVISION DETAIL
  https://phabricator.kde.org/D9824

To: mwolff, dfaure, rjvbb, #kdevelop
Cc: #frameworks
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20180111/af045ef0/attachment-0001.html>